fix(suite-native): bottomsheet container has fixed size #15853
Conversation
|
🚀 Expo preview is ready!
|
| width: SCREEN_SIZE.width, | ||
| height: SCREEN_SIZE.height, |
There was a problem hiding this comment.
What about using EnvUtils instead?
There was a problem hiding this comment.
Yes, and the name screen_size is confusing since it is window size...
There was a problem hiding this comment.
EnvUtils use the same thing under the hood. But sure I can use it
There was a problem hiding this comment.
Yes, that is why you should use it...
There was a problem hiding this comment.
We should probably then replace all usage of Dimensions.get('screen') and replace it by this through the app, because that is how it is being used for now.
There was a problem hiding this comment.
Yes, we should... Thanks for this change!
|
/rebase |
|
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/12254147562 |
trezor-ci
force-pushed
the
fi/native/bottomsheet-jumps
branch
from
f379a0f to
aac9d29
Compare
make fixed size container for bottomsheet not to jump
Related Issue
Resolve #15852
Screenshots:
Screen.Recording.2024-12-09.at.23.19.41.mov