fix(suite): HiddenPlaceholder flickering #15921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lemonexe
commented
Dec 11, 2024
| // prevent flickering that may happen when mouse cursor stands still exactly at the element edge | ||
| if ( | ||
| approxEqual(clientX, mouseEnteredAtCoords?.clientX) && | ||
| approxEqual(clientY, mouseEnteredAtCoords?.clientY) |
There was a problem hiding this comment.
empirically, event.clientX/Y are always integers (firefox, chrome), but according to mdn docs it's a double float, so let's treat it accordingly
peter-sanderson
approved these changes
Dec 13, 2024
|
/rebase |
|
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/12316964426 |
trezor-ci
force-pushed
the
fix/HiddenPlaceholder-flickering
branch
from
c84e9d5 to
c59c068
Compare
|
QA OK Info:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix flickering of
HiddenPlaceholderthat can happen when your mouse cursor stands still exactly at element edge.The bug does not happen on most components, only on very few such as
FiatHeader. Though it is quite reliably reproducible there!Screenshots:
Before: it actually looks much worse than the video shows because of its limited FPS 😅
bug.webm
After: with console log when
onMouseMove+ whenonMouseLeavedetects flickering and returnsflickering.stopped.webm