rewrite code avoiding using sp and rworldmap

[damianooldoni]

@SanderDevisscher: the climate function is using sp package. rworldmap is also used, which relies on sp.

It's time to move to sf. In this way we don't need to use packages rgeos and rgdal which are archived since October 2023 and not more available. See failures of GitHub actions. This is not only important for the authomatic checks of this package, but as you are authomatising the indicators workflow, using the trias package in your GitHub Actions will fail.

[SanderDevisscher]

I'll look into it

[SanderDevisscher]

@soriadelva will look into this under my supervision.

[damianooldoni]

Thanks for the update. I have added her just now to trias as member.

[soriadelva]

@damianooldoni, the RDA data files currently provide the climate data as SpatialPolygonsDataFrame and Sander and me were wondering if it could be useful to recode them as sf objects?

[damianooldoni]

👋 @soriadelva!
Making geojson files of them means that they are not anymore available as internal data (R objects). That means that the user will have to load them every time he/she needs. Notice also that they are structured objects:

> class(observed)
[1] "list"
> names(observed)
[1] "1901-1925" "1926-1950" "1951-1975" "1976-2000" "1980-2016"

> class(future)
[1] "list"
> names(future)
[1] "2001-2025-A1FI" "2026-2050-A1FI" "2051-2075-A1FI" "2076-2100-A1FI" "2071-2100_Beck"

> class(legends)
[1] "list"
> names(legends)
[1] "KG_A1FI" "KG_Beck"

So, saving them as geojson would mean we will have 10 geojson file (5 from futures, 5 from legends). And what to do with legends? Will we save them as two csv files? They are two data.frames.

It will make everything quite complex for everybody, I think.

I would just convert future and observed to two lists of sf:

library(sf)
library(purrr)
observed_sf <- purrr::map(observed, function(x) sf::st_as_sf(x))
future_sf <- purrr::map(future, function(x) sf::st_as_sf(x))

and then overwriting the .rda files.

[soriadelva]

@damianooldoni thanks for the reply! I'll convert them to two lists of sf.