Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking changes gratia #114

Conversation

damianooldoni
Copy link
Collaborator

@damianooldoni damianooldoni commented Apr 11, 2024

This PR fixes #113 by adapting apply_gam() to the breaking changes in gratia 0.9.0.

  • Adapt function
  • Adapt documentation (if needed)
  • Update tests
  • Minor changes (e.g. tidyselect compliance to avoid deprecation warnings)

@damianooldoni damianooldoni changed the base branch from 110-rewrite-code-avoiding-using-sp-and-rworldmap to main April 16, 2024 09:20
@damianooldoni damianooldoni changed the base branch from main to 110-rewrite-code-avoiding-using-sp-and-rworldmap April 16, 2024 09:22
@damianooldoni
Copy link
Collaborator Author

I will close this PR as I was wrong while selecting the target branch: we don't want to push changes to the branch 110-rewrite-code-avoiding-using-sp-and-rworldmap as the proposed changes have nothing to do with that branch.

Changing the target branch to main will not solve the problem as I pulled 110-rewrite-code-avoiding-using-sp-and-rworldmap in this branch.

@damianooldoni damianooldoni deleted the fix-breaking-changes-gratia branch April 16, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant