Skip to content

Commit 24b1c4c

Browse files
bjorn3squell
authored andcommitted
Remove outdated TODO and outdated test disables
1 parent 8c5080f commit 24b1c4c

File tree

3 files changed

+0
-15
lines changed

3 files changed

+0
-15
lines changed

src/log/mod.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ use std::sync::OnceLock;
88
mod simple_logger;
99
mod syslog;
1010

11-
// TODO: logger_macro has an allow_unused that should be removed
1211
macro_rules! logger_macro {
1312
($name:ident is $rule_level:ident to $target:expr, $d:tt) => {
1413
macro_rules! $name {

test-framework/sudo-compliance-tests/src/sudo/sudoers/run_as.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -305,11 +305,6 @@ fn when_no_run_as_spec_then_target_user_cannot_be_a_regular_user() {
305305

306306
#[test]
307307
fn when_no_run_as_spec_then_an_arbitrary_target_group_may_not_be_specified() {
308-
if sudo_test::sudo_version() < sudo_test::ogsudo("1.9.14p2") {
309-
// original sudo should pass this test after 1.9.14p2
310-
return;
311-
}
312-
313308
let env = Env("ALL ALL = NOPASSWD: ALL")
314309
.user(User(USERNAME))
315310
.group(GROUPNAME)

test-framework/sudo-compliance-tests/src/sudo/sudoers/runas_alias.rs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -298,10 +298,6 @@ fn user_and_group_works_when_one_is_passed_as_arg() {
298298

299299
#[test]
300300
fn user_and_group_succeeds_when_both_are_passed() {
301-
if sudo_test::sudo_version() < sudo_test::ogsudo("1.9.14p2") {
302-
return;
303-
}
304-
305301
let env = Env([
306302
&format!("Runas_Alias OP = otheruser, {GROUPNAME}"),
307303
&format!("{USERNAME} ALL = (OP:OP) NOPASSWD: ALL"),
@@ -347,11 +343,6 @@ fn different_aliases_user_and_group_works_when_one_is_passed_as_arg() {
347343

348344
#[test]
349345
fn different_aliases_user_and_group_succeeds_when_both_are_passed() {
350-
if sudo_test::is_original_sudo() {
351-
// TODO: original sudo should pass this test after 1.9.14b2
352-
return;
353-
}
354-
355346
let env = Env([
356347
&format!("Runas_Alias GROUPALIAS = {GROUPNAME}"),
357348
("Runas_Alias USERALIAS = otheruser"),

0 commit comments

Comments
 (0)