Skip to content

Remove outdated TODO and outdated test disables #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2025
Merged

Remove outdated TODO and outdated test disables #1357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/log/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ use std::sync::OnceLock;
mod simple_logger;
mod syslog;

// TODO: logger_macro has an allow_unused that should be removed
macro_rules! logger_macro {
($name:ident is $rule_level:ident to $target:expr, $d:tt) => {
macro_rules! $name {
Expand Down
5 changes: 0 additions & 5 deletions test-framework/sudo-compliance-tests/src/sudo/sudoers/run_as.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,11 +305,6 @@ fn when_no_run_as_spec_then_target_user_cannot_be_a_regular_user() {

#[test]
fn when_no_run_as_spec_then_an_arbitrary_target_group_may_not_be_specified() {
if sudo_test::sudo_version() < sudo_test::ogsudo("1.9.14p2") {
// original sudo should pass this test after 1.9.14p2
return;
}

let env = Env("ALL ALL = NOPASSWD: ALL")
.user(User(USERNAME))
.group(GROUPNAME)
Expand Down
9 changes: 0 additions & 9 deletions test-framework/sudo-compliance-tests/src/sudo/sudoers/runas_alias.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,10 +298,6 @@ fn user_and_group_works_when_one_is_passed_as_arg() {

#[test]
fn user_and_group_succeeds_when_both_are_passed() {
if sudo_test::sudo_version() < sudo_test::ogsudo("1.9.14p2") {
return;
}

let env = Env([
&format!("Runas_Alias OP = otheruser, {GROUPNAME}"),
&format!("{USERNAME} ALL = (OP:OP) NOPASSWD: ALL"),
Expand Down Expand Up @@ -347,11 +343,6 @@ fn different_aliases_user_and_group_works_when_one_is_passed_as_arg() {

#[test]
fn different_aliases_user_and_group_succeeds_when_both_are_passed() {
if sudo_test::is_original_sudo() {
// TODO: original sudo should pass this test after 1.9.14b2
return;
}

let env = Env([
&format!("Runas_Alias GROUPALIAS = {GROUPNAME}"),
("Runas_Alias USERALIAS = otheruser"),
Expand Down
Loading