make it clear we are tracking events, not transactions

Author: ericallam

apps/webapp/app/services/runsReplicationService.server.ts

@@ -121,7 +121,7 @@ export class RunsReplicationService {
   private _taskRunsInsertedCounter: Counter;
   private _payloadsInsertedCounter: Counter;
   private _insertRetriesCounter: Counter;
-  private _transactionsProcessedCounter: Counter;
+  private _eventsProcessedCounter: Counter;
   private _flushDurationHistogram: Histogram;
 
   public readonly events: EventEmitter<RunsReplicationServiceEvents>;
@@ -171,10 +171,10 @@ export class RunsReplicationService {
       description: "Insert retry attempts",
     });
 
-    this._transactionsProcessedCounter = this._meter.createCounter(
-      "runs_replication.transactions_processed",
+    this._eventsProcessedCounter = this._meter.createCounter(
+      "runs_replication.events_processed",
       {
-        description: "Transactions received from replication",
+        description: "Replication events processed (inserts, updates, deletes)",
       }
     );
 
@@ -503,7 +503,7 @@ export class RunsReplicationService {
 
     // Count events by type
     for (const event of transaction.events) {
-      this._transactionsProcessedCounter.add(1, { event_type: event.tag });
+      this._eventsProcessedCounter.add(1, { event_type: event.tag });
     }
 
     this.logger.info("handle_transaction", {

apps/webapp/test/runsReplicationService.part1.test.ts

@@ -1258,36 +1258,6 @@ describe("RunsReplicationService (part 1/2)", () => {
         return metric.dataPoints.reduce((sum: number, dp: any) => sum + (dp.value || 0), 0);
       }
 
-      function getCounterValueByAttributes(
-        metric: any,
-        attributes: Record<string, unknown>
-      ): number {
-        if (!metric?.dataPoints) return 0;
-        for (const dp of metric.dataPoints) {
-          const dpAttrs = dp.attributes || {};
-          const matches = Object.entries(attributes).every(
-            ([key, value]) => String(dpAttrs[key]) === String(value)
-          );
-          if (matches) {
-            return dp.value || 0;
-          }
-        }
-        return 0;
-      }
-
-      function getHistogramCount(metric: any): number {
-        if (!metric?.dataPoints) return 0;
-        return metric.dataPoints.reduce((sum: number, dp: any) => {
-          if (typeof dp.count === "number") return sum + dp.count;
-          if (typeof dp.value?.count === "number") return sum + dp.value.count;
-          if (typeof dp.zeroCount === "number") return sum + dp.zeroCount;
-          if (dp.buckets?.counts) {
-            return sum + dp.buckets.counts.reduce((s: number, c: number) => s + c, 0);
-          }
-          return sum;
-        }, 0);
-      }
-
       function histogramHasData(metric: any): boolean {
         if (!metric?.dataPoints || metric.dataPoints.length === 0) return false;
         return metric.dataPoints.some((dp: any) => {
@@ -1327,12 +1297,12 @@ describe("RunsReplicationService (part 1/2)", () => {
       const totalPayloadsInserted = sumCounterValues(payloadsInserted);
       expect(totalPayloadsInserted).toBeGreaterThanOrEqual(1);
 
-      const transactionsProcessed = getMetricData("runs_replication.transactions_processed");
-      expect(transactionsProcessed).not.toBeNull();
-      const totalTransactionsProcessed = sumCounterValues(transactionsProcessed);
-      expect(totalTransactionsProcessed).toBeGreaterThanOrEqual(1);
+      const eventsProcessed = getMetricData("runs_replication.events_processed");
+      expect(eventsProcessed).not.toBeNull();
+      const totalEventsProcessed = sumCounterValues(eventsProcessed);
+      expect(totalEventsProcessed).toBeGreaterThanOrEqual(1);
 
-      const eventTypes = getCounterAttributeValues(transactionsProcessed, "event_type");
+      const eventTypes = getCounterAttributeValues(eventsProcessed, "event_type");
       expect(eventTypes.length).toBeGreaterThanOrEqual(1);
       expect(eventTypes).toContain("insert");
 

docker/config/grafana/provisioning/dashboards/runs-replication.json

@@ -191,12 +191,12 @@
       },
       "targets": [
         {
-          "expr": "sum(rate(triggerdotdev_runs_replication_transactions_processed_total[5m])) by (event_type)",
+          "expr": "sum(rate(triggerdotdev_runs_replication_events_processed_total[5m])) by (event_type)",
           "legendFormat": "{{event_type}}",
           "refId": "A"
         }
       ],
-      "title": "Transactions Processed by Event Type",
+      "title": "Events Processed by Type",
       "type": "timeseries"
     },
     {
@@ -412,54 +412,7 @@
         },
         "overrides": []
       },
-      "gridPos": { "h": 8, "w": 8, "x": 0, "y": 25 },
-      "id": 12,
-      "options": {
-        "legend": { "calcs": ["mean", "max"], "displayMode": "table", "placement": "bottom", "showLegend": true },
-        "tooltip": { "mode": "multi", "sort": "desc" }
-      },
-      "targets": [
-        {
-          "expr": "triggerdotdev_runs_replication_flush_queue_depth",
-          "legendFormat": "Queue Depth",
-          "refId": "A"
-        }
-      ],
-      "title": "Flush Queue Depth",
-      "type": "timeseries"
-    },
-    {
-      "datasource": { "type": "prometheus", "uid": "prometheus" },
-      "fieldConfig": {
-        "defaults": {
-          "color": { "mode": "palette-classic" },
-          "custom": {
-            "axisBorderShow": false,
-            "axisCenteredZero": false,
-            "axisColorMode": "text",
-            "axisLabel": "",
-            "axisPlacement": "auto",
-            "barAlignment": 0,
-            "drawStyle": "line",
-            "fillOpacity": 10,
-            "gradientMode": "none",
-            "hideFrom": { "legend": false, "tooltip": false, "viz": false },
-            "lineInterpolation": "linear",
-            "lineWidth": 1,
-            "pointSize": 5,
-            "scaleDistribution": { "type": "linear" },
-            "showPoints": "never",
-            "spanNulls": false,
-            "stacking": { "group": "A", "mode": "none" },
-            "thresholdsStyle": { "mode": "off" }
-          },
-          "mappings": [],
-          "thresholds": { "mode": "absolute", "steps": [{ "color": "green", "value": null }] },
-          "unit": "short"
-        },
-        "overrides": []
-      },
-      "gridPos": { "h": 8, "w": 8, "x": 8, "y": 25 },
+      "gridPos": { "h": 8, "w": 12, "x": 0, "y": 25 },
       "id": 13,
       "options": {
         "legend": { "calcs": ["mean", "max"], "displayMode": "table", "placement": "bottom", "showLegend": true },
@@ -503,7 +456,7 @@
         },
         "overrides": []
       },
-      "gridPos": { "h": 8, "w": 8, "x": 16, "y": 25 },
+      "gridPos": { "h": 8, "w": 12, "x": 12, "y": 25 },
       "id": 14,
       "options": {
         "colorMode": "value",