Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modus Table - Bugs #2701

Open
2 tasks done
venkyn13 opened this issue Jul 18, 2024 · 3 comments
Open
2 tasks done

Modus Table - Bugs #2701

venkyn13 opened this issue Jul 18, 2024 · 3 comments
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble Version 1.x

Comments

@venkyn13
Copy link
Contributor

Prerequisites

Describe the issue

  1. Rowoptions column width needs to be small and fixed, right now it is 90 px
  2. Dropdown menu has alignment issue, like dropdown menu options is not fully visible on bottom row
  3. Rowselection column width needs to be small and fixed (this issue is similar to issue 1)
  4. Right now, available table displayOptions are borderless and cellborderless, but we need the border only after each row(like in modus react Datatable).

Reduced test cases

No response

What operating system(s) are you seeing the problem on?

No response

What browser(s) are you seeing the problem on?

No response

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

No response

Priority

High

What product/project are you using Modus Components for ?

Field data

What is your team/division name ?

Geospatial - CPD

Are you willing to contribute ?

None

Are you using Modus Web Components in production ?

No response

@venkyn13 venkyn13 added the bug Something is wrong and needs to be addressed label Jul 18, 2024
Copy link

Hello @venkyn13! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Jul 18, 2024
@prashanth-offcl prashanth-offcl moved this from In Review to Refinement in Modus Web Components Aug 20, 2024
@prashanth-offcl
Copy link
Contributor

@venkyn13 The issues mentioned will be addressed in a separate issues and I've linked it. Please check and tell if that address all your concerns.

  1. Rowoptions column width needs to be small and fixed, right now it is 90 px - Will be addressed in Table: Uneven width on row selection and row action column #1922
  2. Dropdown menu has alignment issue, like dropdown menu options is not fully visible on bottom row - Will be addressed in Table - Autocomplete & Date cellEditorType : dropdown is hidden behind grid container (date and select) #2783
  3. Rowselection column width needs to be small and fixed (this issue is similar to issue 1) - Will be addressed in Table: Uneven width on row selection and row action column #1922
  4. Right now, available table displayOptions are borderless and cellborderless, but we need the border only after each row(like in modus react Datatable) - Fixed in Borderless table should have bottom line #2675

@venkyn13
Copy link
Contributor Author

venkyn13 commented Aug 23, 2024

@prashanth-offcl, I have checked the above mentioned issues and on 2nd issue, in addition to 'dropdown is hidden behind grid container', please double check that the 'actual dropdown menu options alignment is correct' - like when i click dropdown menu the options should be aligned based on available space(if there is enough space on right, it should be at right, else at left and the same for top and bottom)

Apart from this, everything is ok for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble Version 1.x
Projects
Status: Refinement
Development

No branches or pull requests

3 participants