Skip to content

Table: add a maxWidth to the row actions column #2753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
leosole-trimble opened this issue Aug 5, 2024 · 4 comments
Closed
2 tasks done

Table: add a maxWidth to the row actions column #2753

leosole-trimble opened this issue Aug 5, 2024 · 4 comments
Labels
external-request Bugs and features reported by individuals from other teams in Trimble modus-table Modus Table component development

Comments

@leosole-trimble
Copy link
Contributor

Prerequisites

Proposal

For tables with a small number of columns, the row actions column might become too large, and there is no way of controlling it, since there are no width properties the user can set.
This column could have a fixed width calculated by the number of actions in it. This already happens for tables with lots of columns, the row actions are fixed at the end of the row with a pre calculated width

Few columns and unnecessary large row actions width:
image

Lots of columns and fixed width:
image

Motivation and context

No response

What is the issue regarding ?

@trimble-oss/modus-web-components

Priority

Medium

What product/project are you using Modus Components for ?

Trimble Inspections

What is your team/division name ?

Camaleão/Transportation

Are you willing to contribute ?

No

Are you using Modus Web Components in production ?

No response

Copy link

github-actions bot commented Aug 5, 2024

Hello @leosole-trimble! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Aug 5, 2024
@prashanth-offcl prashanth-offcl added the modus-table Modus Table component development label Aug 6, 2024
@prashanth-offcl
Copy link
Contributor

@prashanth-offcl to check and decide the prop name to allow the integrator to set the column width.

@prashanth-offcl
Copy link
Contributor

Related to #1922

@prashanth-offcl
Copy link
Contributor

prashanth-offcl commented Oct 1, 2024

Duplicate of #1922

@github-project-automation github-project-automation bot moved this from To Do to Done in Modus Web Components Oct 1, 2024
@prashanth-offcl prashanth-offcl marked this as a duplicate of #1922 Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-request Bugs and features reported by individuals from other teams in Trimble modus-table Modus Table component development
Projects
Archived in project
Development

No branches or pull requests

2 participants