Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Row Selection column sizing regression in 0.36 #2807

Closed
2 tasks done
Kai-Richardson opened this issue Aug 23, 2024 · 3 comments
Closed
2 tasks done

Table: Row Selection column sizing regression in 0.36 #2807

Kai-Richardson opened this issue Aug 23, 2024 · 3 comments
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble

Comments

@Kai-Richardson
Copy link

Kai-Richardson commented Aug 23, 2024

Prerequisites

Describe the issue

image

A regression was introduced impacting the sizing of the rowSelection column for ModusTable. It now seems to act a fluid box or something strange, though I don't see anything in css. It might be the internal width calculation.

I can reproduce this in our project by simply changing the installed version of modus.

You can work around it by manually setting the width of the other columns, though this is pretty terrible.

#2014 might be relevant/fix. Unsure though.

Reduced test cases

This is present in the storybook, seemingly? It's rendering super strangely.
https://modus-web-components.trimble.com/?path=/story/components-table--checkbox-row-selection

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome, Microsoft Edge

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

0.36.0-react18

Priority

High

What product/project are you using Modus Components for ?

Viewpoint Cascade

What is your team/division name ?

Cascade

Are you willing to contribute ?

Maybe

Are you using Modus Web Components in production ?

Imminently

@Kai-Richardson Kai-Richardson added the bug Something is wrong and needs to be addressed label Aug 23, 2024
Copy link

Hello @Kai-Richardson! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Aug 23, 2024
@prashanth-offcl
Copy link
Contributor

Related to #1922

@prashanth-offcl prashanth-offcl changed the title Modus Table - Row Selection column sizing regression in 0.36 Table: Row Selection column sizing regression in 0.36 Aug 27, 2024
@Kai-Richardson
Copy link
Author

Fixed in v0.38.0
Likely fixed by #2829

@github-project-automation github-project-automation bot moved this from In Review to Done in Modus Web Components Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble
Projects
Archived in project
Development

No branches or pull requests

2 participants