Skip to content

Dropdown formatting: fix corner radii #3000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
enowak1031 opened this issue Nov 20, 2024 · 2 comments · Fixed by #3070
Closed

Dropdown formatting: fix corner radii #3000

enowak1031 opened this issue Nov 20, 2024 · 2 comments · Fixed by #3070
Assignees
@ElishaSamPeterPrabhu
Labels
bug Something is wrong and needs to be addressed priority:high Prioritization for this item is high

Comments

@enowak1031
Copy link

enowak1031 commented Nov 20, 2024 •
edited
Loading

In the dropdown component, the list container and highlight for selected items have rounded corners. They should be square. Related to side navigation issue #2927
@enowak1031 enowak1031 converted this from a draft issue Nov 20, 2024
@enowak1031 enowak1031 added bug Something is wrong and needs to be addressed priority:high Prioritization for this item is high labels Nov 20, 2024
@ElishaSamPeterPrabhu
Copy link
Collaborator

@enowak1031 Will the dropdown component have radius set to be 0 or is this specific to the advanced chips(#2911 ) or #2927 issues?

@enowak1031
Copy link
Author

Ideally we would like to change the corner radius to 0 pixels for all dropdowns with an option to customize it or increase it to 2 or 4 pixels.

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu self-assigned this Dec 16, 2024
Merged
13 tasks
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu linked a pull request Dec 16, 2024 that will close this issue
Dropdown: Add border radius property for dropdown list #3070
Merged
13 tasks
@jewel-shajan jewel-shajan moved this from To Do to PR Review in Modus Web Components Dec 17, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in Modus Web Components Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu

Labels
bug Something is wrong and needs to be addressed priority:high Prioritization for this item is high
Projects
Modus Web Components
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dropdown: Add border radius property for dropdown list trimble-oss/modus-web-components
2 participants
@enowak1031 @ElishaSamPeterPrabhu