Skip to content

Commit 0132cdd

Browse files
committed
Convert Assignments to a record class
1 parent 422f3a9 commit 0132cdd

File tree

2 files changed

+6
-19
lines changed

2 files changed

+6
-19
lines changed

core/trino-main/src/main/java/io/trino/sql/planner/plan/Assignments.java

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -182,25 +182,12 @@ public void forEach(BiConsumer<Symbol, Expression> consumer)
182182
assignments.forEach(consumer);
183183
}
184184

185-
public static class Assignment
185+
public record Assignment(Symbol output, Expression expression)
186186
{
187-
private final Symbol output;
188-
private final Expression expression;
189-
190-
public Assignment(Symbol output, Expression expression)
191-
{
192-
this.output = requireNonNull(output, "output is null");
193-
this.expression = requireNonNull(expression, "expression is null");
194-
}
195-
196-
public Symbol getOutput()
197-
{
198-
return output;
199-
}
200-
201-
public Expression getExpression()
187+
public Assignment
202188
{
203-
return expression;
189+
requireNonNull(output, "output is null");
190+
requireNonNull(expression, "expression is null");
204191
}
205192
}
206193

@@ -260,7 +247,7 @@ public Assignments build()
260247

261248
public Builder add(Assignment assignment)
262249
{
263-
put(assignment.getOutput(), assignment.getExpression());
250+
put(assignment.output(), assignment.expression());
264251
return this;
265252
}
266253
}

core/trino-main/src/test/java/io/trino/sql/planner/assertions/ExpressionMatcher.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public Optional<Symbol> getAssignedSymbol(PlanNode node, Session session, Metada
6969
private static Map<Symbol, Expression> getAssignments(PlanNode node)
7070
{
7171
if (node instanceof ProjectNode projectNode) {
72-
return projectNode.getAssignments().getMap();
72+
return projectNode.getAssignments().assignments();
7373
}
7474
return null;
7575
}

0 commit comments

Comments
 (0)