Skip to content

Commit 34a297c

Browse files
committed
Replace duplicated method
1 parent 4e99d36 commit 34a297c

File tree

42 files changed

+55
-59
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+55
-59
lines changed

core/trino-main/src/main/java/io/trino/sql/planner/ExpressionExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public Void visitFilter(FilterNode node, Void context)
110110
@Override
111111
public Void visitProject(ProjectNode node, Void context)
112112
{
113-
node.getAssignments().getExpressions().forEach(consumer);
113+
node.getAssignments().expressions().forEach(consumer);
114114
return super.visitProject(node, context);
115115
}
116116

core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1301,7 +1301,7 @@ private PlanBuilder planAggregation(PlanBuilder subPlan, List<List<Symbol>> grou
13011301
}
13021302
}
13031303

1304-
ImmutableList.Builder<Symbol> groupingKeys = ImmutableList.builder();
1304+
ImmutableSet.Builder<Symbol> groupingKeys = ImmutableSet.builder();
13051305
groupingSets.stream()
13061306
.flatMap(List::stream)
13071307
.distinct()

core/trino-main/src/main/java/io/trino/sql/planner/iterative/rule/DecorrelateInnerUnnestWithGlobalAggregation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ private static boolean isSupportedUnnest(PlanNode node, List<Symbol> correlation
261261
PlanNode unnestSource = lookup.resolve(unnestNode.getSource());
262262
Set<Symbol> correlationSymbols = ImmutableSet.copyOf(correlation);
263263
boolean basedOnCorrelation = correlationSymbols.containsAll(unnestSymbols) ||
264-
unnestSource instanceof ProjectNode projectNode && correlationSymbols.containsAll(SymbolsExtractor.extractUnique(projectNode.getAssignments().getExpressions()));
264+
unnestSource instanceof ProjectNode projectNode && correlationSymbols.containsAll(SymbolsExtractor.extractUnique(projectNode.getAssignments().expressions()));
265265

266266
return isScalar(unnestNode.getSource(), lookup) &&
267267
unnestNode.getReplicateSymbols().isEmpty() &&

core/trino-main/src/main/java/io/trino/sql/planner/iterative/rule/DecorrelateLeftUnnestWithGlobalAggregation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ private static boolean isSupportedUnnest(PlanNode node, List<Symbol> correlation
217217
.collect(toImmutableList());
218218
PlanNode unnestSource = lookup.resolve(unnestNode.getSource());
219219
boolean basedOnCorrelation = ImmutableSet.copyOf(correlation).containsAll(unnestSymbols) ||
220-
unnestSource instanceof ProjectNode projectNode && ImmutableSet.copyOf(correlation).containsAll(SymbolsExtractor.extractUnique(projectNode.getAssignments().getExpressions()));
220+
unnestSource instanceof ProjectNode projectNode && ImmutableSet.copyOf(correlation).containsAll(SymbolsExtractor.extractUnique(projectNode.getAssignments().expressions()));
221221

222222
return isScalar(unnestNode.getSource(), lookup) &&
223223
unnestNode.getReplicateSymbols().isEmpty() &&

core/trino-main/src/main/java/io/trino/sql/planner/iterative/rule/DecorrelateUnnest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ private static boolean isSupportedUnnest(PlanNode node, List<Symbol> correlation
296296
.collect(toImmutableList());
297297
PlanNode unnestSource = lookup.resolve(unnestNode.getSource());
298298
boolean basedOnCorrelation = ImmutableSet.copyOf(correlation).containsAll(unnestSymbols) ||
299-
unnestSource instanceof ProjectNode projectNode && ImmutableSet.copyOf(correlation).containsAll(SymbolsExtractor.extractUnique(projectNode.getAssignments().getExpressions()));
299+
unnestSource instanceof ProjectNode projectNode && ImmutableSet.copyOf(correlation).containsAll(SymbolsExtractor.extractUnique(projectNode.getAssignments().expressions()));
300300

301301
return isScalar(unnestNode.getSource(), lookup) &&
302302
unnestNode.getReplicateSymbols().isEmpty() &&

core/trino-main/src/main/java/io/trino/sql/planner/iterative/rule/GatherAndMergeWindows.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ protected static Optional<WindowNode> pullWindowNodeAboveProjects(
152152
.putIdentities(targetInputs)
153153
.build();
154154

155-
if (!newTargetChildOutputs.containsAll(SymbolsExtractor.extractUnique(newAssignments.getExpressions()))) {
155+
if (!newTargetChildOutputs.containsAll(SymbolsExtractor.extractUnique(newAssignments.expressions()))) {
156156
// Projection uses an output of the target -- can't move the target above this projection.
157157
return Optional.empty();
158158
}

core/trino-main/src/main/java/io/trino/sql/planner/iterative/rule/InlineProjectIntoFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ public Result apply(FilterNode node, Captures captures, Context context)
159159
return Result.empty();
160160
}
161161

162-
Set<Symbol> postFilterSymbols = postFilterAssignments.getSymbols();
162+
Set<Symbol> postFilterSymbols = postFilterAssignments.outputs();
163163
// Remove inlined expressions from the underlying projection.
164164
newAssignments.putAll(projectNode.getAssignments().filter(symbol -> !postFilterSymbols.contains(symbol)));
165165

core/trino-main/src/main/java/io/trino/sql/planner/iterative/rule/InlineProjections.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ private static Set<Symbol> extractInliningTargets(ProjectNode parent, ProjectNod
161161
Set<Symbol> childOutputSet = ImmutableSet.copyOf(child.getOutputSymbols());
162162

163163
Map<Symbol, Long> dependencies = parent.getAssignments()
164-
.getExpressions().stream()
164+
.expressions().stream()
165165
.flatMap(expression -> SymbolsExtractor.extractAll(expression).stream())
166166
.filter(childOutputSet::contains)
167167
.collect(Collectors.groupingBy(Function.identity(), Collectors.counting()));

core/trino-main/src/main/java/io/trino/sql/planner/iterative/rule/MergePatternRecognitionNodes.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ public Result apply(PatternRecognitionNode node, Captures captures, Context cont
137137
// put prerequisite assignments in the source of merged node,
138138
// and the remaining assignments on top of merged node
139139
Assignments remainingAssignments = project.getAssignments()
140-
.filter(symbol -> !prerequisites.getSymbols().contains(symbol));
140+
.filter(symbol -> !prerequisites.outputs().contains(symbol));
141141

142142
merged = (PatternRecognitionNode) merged.replaceChildren(ImmutableList.of(new ProjectNode(
143143
context.getIdAllocator().getNextId(),

core/trino-main/src/main/java/io/trino/sql/planner/iterative/rule/OptimizeDuplicateInsensitiveJoins.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ public Optional<PlanNode> visitFilter(FilterNode node, Void context)
103103
@Override
104104
public Optional<PlanNode> visitProject(ProjectNode node, Void context)
105105
{
106-
boolean isDeterministic = node.getAssignments().getExpressions().stream()
106+
boolean isDeterministic = node.getAssignments().expressions().stream()
107107
.allMatch(DeterminismEvaluator::isDeterministic);
108108
if (!isDeterministic) {
109109
// non-deterministic projections could be used in downstream filters which could

0 commit comments

Comments
 (0)