Allow metastore impersonation in tests

ebyhr · ebyhr · commit 605483548fdf · 2025-10-25T09:39:31.000+09:00
diff --git a/lib/trino-metastore/src/main/java/io/trino/metastore/HiveMetastoreFactory.java b/lib/trino-metastore/src/main/java/io/trino/metastore/HiveMetastoreFactory.java
@@ -35,25 +35,27 @@ default boolean hasBuiltInCaching()
      */
     HiveMetastore createMetastore(Optional<ConnectorIdentity> identity);
 
-    static HiveMetastoreFactory ofInstance(HiveMetastore metastore)
+    static HiveMetastoreFactory ofInstance(HiveMetastore metastore, boolean impersonationEnabled)
     {
-        return new StaticHiveMetastoreFactory(metastore);
+        return new StaticHiveMetastoreFactory(metastore, impersonationEnabled);
     }
 
     class StaticHiveMetastoreFactory
             implements HiveMetastoreFactory
     {
         private final HiveMetastore metastore;
+        private final boolean impersonationEnabled;
 
-        private StaticHiveMetastoreFactory(HiveMetastore metastore)
+        private StaticHiveMetastoreFactory(HiveMetastore metastore, boolean impersonationEnabled)
         {
             this.metastore = requireNonNull(metastore, "metastore is null");
+            this.impersonationEnabled = impersonationEnabled;
         }
 
         @Override
         public boolean isImpersonationEnabled()
         {
-            return false;
+            return impersonationEnabled;
         }
 
         @Override
diff --git a/plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeSplitManager.java b/plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeSplitManager.java
@@ -221,7 +221,7 @@ public Stream<AddFileEntry> getActiveFiles(
                 newDirectExecutorService());
 
         TransactionLogReaderFactory transactionLogReaderFactory = new FileSystemTransactionLogReaderFactory(fileSystemFactory);
-        HiveMetastoreFactory hiveMetastoreFactory = HiveMetastoreFactory.ofInstance(createTestingFileHiveMetastore(new MemoryFileSystemFactory(), Location.of("memory:///")));
+        HiveMetastoreFactory hiveMetastoreFactory = HiveMetastoreFactory.ofInstance(createTestingFileHiveMetastore(new MemoryFileSystemFactory(), Location.of("memory:///")), false);
         DeltaLakeMetadataFactory metadataFactory = new DeltaLakeMetadataFactory(
                 hiveMetastoreFactory,
                 new DefaultDeltaLakeFileSystemFactory(hdfsFileSystemFactory, new NoOpVendedCredentialsProvider()),
diff --git a/plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/metastore/TestingDeltaLakeMetastoreModule.java b/plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/metastore/TestingDeltaLakeMetastoreModule.java
@@ -41,7 +41,7 @@ public TestingDeltaLakeMetastoreModule(HiveMetastore metastore)
     @Override
     public void setup(Binder binder)
     {
-        binder.bind(HiveMetastoreFactory.class).annotatedWith(RawHiveMetastoreFactory.class).toInstance(HiveMetastoreFactory.ofInstance(metastore));
+        binder.bind(HiveMetastoreFactory.class).annotatedWith(RawHiveMetastoreFactory.class).toInstance(HiveMetastoreFactory.ofInstance(metastore, false));
         install(new CachingHiveMetastoreModule());
         binder.bind(DeltaLakeTableOperationsProvider.class).to(DeltaLakeFileMetastoreTableOperationsProvider.class).in(Scopes.SINGLETON);
 
diff --git a/plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveConnectorFactory.java b/plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveConnectorFactory.java
@@ -71,7 +71,7 @@ public String getName()
     public Connector create(String catalogName, Map<String, String> config, ConnectorContext context)
     {
         checkStrictSpiVersionMatch(context, this);
-        return createConnector(catalogName, config, context, EMPTY_MODULE, Optional.empty(), Optional.empty());
+        return createConnector(catalogName, config, context, EMPTY_MODULE, Optional.empty(), false, Optional.empty());
     }
 
     public static Connector createConnector(
@@ -80,6 +80,7 @@ public static Connector createConnector(
             ConnectorContext context,
             Module module,
             Optional<HiveMetastore> metastore,
+            boolean metastoreImpersonationEnabled,
             Optional<TrinoFileSystemFactory> fileSystemFactory)
     {
         ClassLoader classLoader = HiveConnectorFactory.class.getClassLoader();
@@ -91,7 +92,7 @@ public static Connector createConnector(
                     new JsonModule(),
                     new TypeDeserializerModule(),
                     new HiveModule(),
-                    new HiveMetastoreModule(metastore),
+                    new HiveMetastoreModule(metastore, metastoreImpersonationEnabled),
                     new HiveSecurityModule(),
                     fileSystemFactory
                             .map(factory -> (Module) binder -> binder.bind(TrinoFileSystemFactory.class).toInstance(factory))
diff --git a/plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/HiveMetastoreModule.java b/plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/HiveMetastoreModule.java
@@ -30,17 +30,19 @@ public class HiveMetastoreModule
         extends AbstractConfigurationAwareModule
 {
     private final Optional<HiveMetastore> metastore;
+    private final boolean impersonationEnabled;
 
-    public HiveMetastoreModule(Optional<HiveMetastore> metastore)
+    public HiveMetastoreModule(Optional<HiveMetastore> metastore, boolean impersonationEnabled)
     {
         this.metastore = metastore;
+        this.impersonationEnabled = impersonationEnabled;
     }
 
     @Override
     protected void setup(Binder binder)
     {
         if (metastore.isPresent()) {
-            binder.bind(HiveMetastoreFactory.class).annotatedWith(RawHiveMetastoreFactory.class).toInstance(HiveMetastoreFactory.ofInstance(metastore.get()));
+            binder.bind(HiveMetastoreFactory.class).annotatedWith(RawHiveMetastoreFactory.class).toInstance(HiveMetastoreFactory.ofInstance(metastore.get(), impersonationEnabled));
             binder.bind(Key.get(boolean.class, AllowHiveTableRename.class)).toInstance(true);
         }
         else {
diff --git a/plugin/trino-hive/src/test/java/io/trino/plugin/hive/HiveQueryRunner.java b/plugin/trino-hive/src/test/java/io/trino/plugin/hive/HiveQueryRunner.java
@@ -47,6 +47,7 @@
 
 import static io.airlift.log.Level.WARN;
 import static io.airlift.units.Duration.nanosSince;
+import static io.trino.plugin.hive.HiveTestUtils.SESSION;
 import static io.trino.plugin.hive.TestingHiveUtils.getConnectorService;
 import static io.trino.plugin.tpch.ColumnNaming.SIMPLIFIED;
 import static io.trino.plugin.tpch.DecimalTypeMapping.DOUBLE;
@@ -101,6 +102,7 @@ public static class Builder<SELF extends Builder<?>>
         private List<TpchTable<?>> initialTables = ImmutableList.of();
         private Optional<String> initialSchemasLocationBase = Optional.empty();
         private Optional<Function<DistributedQueryRunner, HiveMetastore>> metastore = Optional.empty();
+        private boolean metastoreImpersonationEnabled;
         private boolean tpcdsCatalogEnabled;
         private boolean tpchBucketedCatalogEnabled;
         private boolean createTpchSchemas = true;
@@ -161,6 +163,13 @@ public SELF setMetastore(Function<DistributedQueryRunner, HiveMetastore> metasto
             return self();
         }
 
+        @CanIgnoreReturnValue
+        public SELF setMetastoreImpersonationEnabled(boolean metastoreImpersonationEnabled)
+        {
+            this.metastoreImpersonationEnabled = metastoreImpersonationEnabled;
+            return self();
+        }
+
         @CanIgnoreReturnValue
         public SELF setTpcdsCatalogEnabled(boolean tpcdsCatalogEnabled)
         {
@@ -236,7 +245,7 @@ public DistributedQueryRunner build()
                     hiveProperties.put("fs.hadoop.enabled", "true");
                 }
 
-                queryRunner.installPlugin(new TestingHivePlugin(dataDir, metastore, decryptionKeyRetriever));
+                queryRunner.installPlugin(new TestingHivePlugin(dataDir, metastore, metastoreImpersonationEnabled, decryptionKeyRetriever));
 
                 Map<String, String> hiveProperties = new HashMap<>();
                 if (!skipTimezoneSetup) {
@@ -280,7 +289,7 @@ public DistributedQueryRunner build()
         private void populateData(QueryRunner queryRunner)
         {
             HiveMetastore metastore = getConnectorService(queryRunner, HiveMetastoreFactory.class)
-                    .createMetastore(Optional.empty());
+                    .createMetastore(Optional.of(SESSION.getIdentity()));
             if (metastore.getDatabase(TPCH_SCHEMA).isEmpty()) {
                 metastore.createDatabase(createDatabaseMetastoreObject(TPCH_SCHEMA, initialSchemasLocationBase));
                 copyTpchTables(queryRunner, "tpch", TINY_SCHEMA_NAME, initialTables);
diff --git a/plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHivePageSink.java b/plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHivePageSink.java
@@ -394,7 +394,7 @@ private static ConnectorPageSink createPageSink(
                 getDefaultHiveFileWriterFactories(config, fileSystemFactory),
                 HDFS_FILE_SYSTEM_FACTORY,
                 PAGE_SORTER,
-                HiveMetastoreFactory.ofInstance(metastore),
+                HiveMetastoreFactory.ofInstance(metastore, false),
                 new GroupByHashPageIndexerFactory(new FlatHashStrategyCompiler(new TypeOperators())),
                 TESTING_TYPE_MANAGER,
                 config,
diff --git a/plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestingHiveConnectorFactory.java b/plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestingHiveConnectorFactory.java
@@ -38,17 +38,23 @@ public class TestingHiveConnectorFactory
         implements ConnectorFactory
 {
     private final Optional<HiveMetastore> metastore;
+    private final boolean metastoreImpersonationEnabled;
     private final Module module;
 
     public TestingHiveConnectorFactory(Path localFileSystemRootPath)
     {
-        this(localFileSystemRootPath, Optional.empty(), Optional.empty());
+        this(localFileSystemRootPath, Optional.empty(), false, Optional.empty());
     }
 
     @Deprecated
-    public TestingHiveConnectorFactory(Path localFileSystemRootPath, Optional<HiveMetastore> metastore, Optional<DecryptionKeyRetriever> decryptionKeyRetriever)
+    public TestingHiveConnectorFactory(
+            Path localFileSystemRootPath,
+            Optional<HiveMetastore> metastore,
+            boolean metastoreImpersonationEnabled,
+            Optional<DecryptionKeyRetriever> decryptionKeyRetriever)
     {
         this.metastore = requireNonNull(metastore, "metastore is null");
+        this.metastoreImpersonationEnabled = metastoreImpersonationEnabled;
 
         boolean ignored = localFileSystemRootPath.toFile().mkdirs();
         this.module = binder -> {
@@ -79,6 +85,6 @@ public Connector create(String catalogName, Map<String, String> config, Connecto
         if (metastore.isEmpty() && !config.containsKey("hive.metastore")) {
             configBuilder.put("hive.metastore", "file");
         }
-        return createConnector(catalogName, configBuilder.buildOrThrow(), context, module, metastore, Optional.empty());
+        return createConnector(catalogName, configBuilder.buildOrThrow(), context, module, metastore, metastoreImpersonationEnabled, Optional.empty());
     }
 }
diff --git a/plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestingHivePlugin.java b/plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestingHivePlugin.java
@@ -29,30 +29,36 @@ public class TestingHivePlugin
 {
     private final Path localFileSystemRootPath;
     private final Optional<HiveMetastore> metastore;
+    private final boolean metastoreImpersonationEnabled;
     private final Optional<DecryptionKeyRetriever> decryptionKeyRetriever;
 
     public TestingHivePlugin(Path localFileSystemRootPath)
     {
-        this(localFileSystemRootPath, Optional.empty(), Optional.empty());
+        this(localFileSystemRootPath, Optional.empty(), false, Optional.empty());
     }
 
     @Deprecated
     public TestingHivePlugin(Path localFileSystemRootPath, HiveMetastore metastore)
     {
-        this(localFileSystemRootPath, Optional.of(metastore), Optional.empty());
+        this(localFileSystemRootPath, Optional.of(metastore), false, Optional.empty());
     }
 
     @Deprecated
-    public TestingHivePlugin(Path localFileSystemRootPath, Optional<HiveMetastore> metastore, Optional<DecryptionKeyRetriever> decryptionKeyRetriever)
+    public TestingHivePlugin(
+            Path localFileSystemRootPath,
+            Optional<HiveMetastore> metastore,
+            boolean metastoreImpersonationEnabled,
+            Optional<DecryptionKeyRetriever> decryptionKeyRetriever)
     {
         this.localFileSystemRootPath = requireNonNull(localFileSystemRootPath, "localFileSystemRootPath is null");
         this.metastore = requireNonNull(metastore, "metastore is null");
+        this.metastoreImpersonationEnabled = metastoreImpersonationEnabled;
         this.decryptionKeyRetriever = requireNonNull(decryptionKeyRetriever, "decryptionKeyRetriever is null");
     }
 
     @Override
     public Iterable<ConnectorFactory> getConnectorFactories()
     {
-        return ImmutableList.of(new TestingHiveConnectorFactory(localFileSystemRootPath, metastore, decryptionKeyRetriever));
+        return ImmutableList.of(new TestingHiveConnectorFactory(localFileSystemRootPath, metastore, metastoreImpersonationEnabled, decryptionKeyRetriever));
     }
 }
diff --git a/plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestingThriftHiveMetastoreBuilder.java b/plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestingThriftHiveMetastoreBuilder.java
@@ -35,6 +35,7 @@
 import static io.trino.plugin.base.security.UserNameProvider.SIMPLE_USER_NAME_PROVIDER;
 import static io.trino.plugin.hive.HiveTestUtils.HDFS_ENVIRONMENT;
 import static io.trino.plugin.hive.HiveTestUtils.HDFS_FILE_SYSTEM_STATS;
+import static io.trino.plugin.hive.HiveTestUtils.SESSION;
 import static io.trino.plugin.hive.metastore.thrift.TestingTokenAwareMetastoreClientFactory.TIMEOUT;
 import static java.util.Objects.requireNonNull;
 import static java.util.concurrent.Executors.newFixedThreadPool;
@@ -108,6 +109,6 @@ public ThriftMetastore build(Consumer<AutoCloseable> registerResource)
                 thriftMetastoreConfig,
                 fileSystemFactory,
                 executorService);
-        return metastoreFactory.createMetastore(Optional.empty());
+        return metastoreFactory.createMetastore(Optional.of(SESSION.getIdentity()));
     }
 }
diff --git a/plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiConnectorFactory.java b/plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiConnectorFactory.java
@@ -73,7 +73,7 @@ public static Connector createConnector(
                     new MBeanModule(),
                     new JsonModule(),
                     new HudiModule(),
-                    new HiveMetastoreModule(Optional.empty()),
+                    new HiveMetastoreModule(Optional.empty(), false),
                     new FileSystemModule(catalogName, context, false),
                     new MBeanServerModule(),
                     module.orElse(EMPTY_MODULE),
diff --git a/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/file/TestingIcebergFileMetastoreCatalogModule.java b/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/file/TestingIcebergFileMetastoreCatalogModule.java
@@ -44,7 +44,7 @@ public TestingIcebergFileMetastoreCatalogModule(HiveMetastore metastore)
     @Override
     protected void setup(Binder binder)
     {
-        binder.bind(HiveMetastoreFactory.class).annotatedWith(RawHiveMetastoreFactory.class).toInstance(HiveMetastoreFactory.ofInstance(metastore));
+        binder.bind(HiveMetastoreFactory.class).annotatedWith(RawHiveMetastoreFactory.class).toInstance(HiveMetastoreFactory.ofInstance(metastore, false));
         install(new CachingHiveMetastoreModule());
         binder.bind(IcebergTableOperationsProvider.class).to(FileMetastoreTableOperationsProvider.class).in(Scopes.SINGLETON);
         binder.bind(TrinoCatalogFactory.class).to(TrinoHiveCatalogFactory.class).in(Scopes.SINGLETON);
diff --git a/plugin/trino-lakehouse/src/main/java/io/trino/plugin/lakehouse/LakehouseHiveModule.java b/plugin/trino-lakehouse/src/main/java/io/trino/plugin/lakehouse/LakehouseHiveModule.java
@@ -77,7 +77,7 @@ class LakehouseHiveModule
     @Override
     protected void setup(Binder binder)
     {
-        install(new HiveMetastoreModule(Optional.empty()));
+        install(new HiveMetastoreModule(Optional.empty(), false));
 
         configBinder(binder).bindConfig(HiveConfig.class);
         configBinder(binder).bindConfig(HiveMetastoreConfig.class);

Original file line number	Diff line number	Diff line change
`@@ -35,25 +35,27 @@ default boolean hasBuiltInCaching()`
`35`	`35`	`*/`
`36`	`36`	`HiveMetastore createMetastore(Optional<ConnectorIdentity> identity);`
`37`	`37`
`38`		`- static HiveMetastoreFactory ofInstance(HiveMetastore metastore)`
	`38`	`+ static HiveMetastoreFactory ofInstance(HiveMetastore metastore, boolean impersonationEnabled)`
`39`	`39`	`{`
`40`		`- return new StaticHiveMetastoreFactory(metastore);`
	`40`	`+ return new StaticHiveMetastoreFactory(metastore, impersonationEnabled);`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`class StaticHiveMetastoreFactory`
`44`	`44`	`implements HiveMetastoreFactory`
`45`	`45`	`{`
`46`	`46`	`private final HiveMetastore metastore;`
	`47`	`+ private final boolean impersonationEnabled;`
`47`	`48`
`48`		`- private StaticHiveMetastoreFactory(HiveMetastore metastore)`
	`49`	`+ private StaticHiveMetastoreFactory(HiveMetastore metastore, boolean impersonationEnabled)`
`49`	`50`	`{`
`50`	`51`	`this.metastore = requireNonNull(metastore, "metastore is null");`
	`52`	`+ this.impersonationEnabled = impersonationEnabled;`
`51`	`53`	`}`
`52`	`54`
`53`	`55`	`@Override`
`54`	`56`	`public boolean isImpersonationEnabled()`
`55`	`57`	`{`
`56`		`- return false;`
	`58`	`+ return impersonationEnabled;`
`57`	`59`	`}`
`58`	`60`
`59`	`61`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public TestingDeltaLakeMetastoreModule(HiveMetastore metastore)`
`41`	`41`	`@Override`
`42`	`42`	`public void setup(Binder binder)`
`43`	`43`	`{`
`44`		`- binder.bind(HiveMetastoreFactory.class).annotatedWith(RawHiveMetastoreFactory.class).toInstance(HiveMetastoreFactory.ofInstance(metastore));`
	`44`	`+ binder.bind(HiveMetastoreFactory.class).annotatedWith(RawHiveMetastoreFactory.class).toInstance(HiveMetastoreFactory.ofInstance(metastore, false));`
`45`	`45`	`install(new CachingHiveMetastoreModule());`
`46`	`46`	`binder.bind(DeltaLakeTableOperationsProvider.class).to(DeltaLakeFileMetastoreTableOperationsProvider.class).in(Scopes.SINGLETON);`
`47`	`47`
Original file line number	Diff line number	Diff line change
`@@ -30,17 +30,19 @@ public class HiveMetastoreModule`
`30`	`30`	`extends AbstractConfigurationAwareModule`
`31`	`31`	`{`
`32`	`32`	`private final Optional<HiveMetastore> metastore;`
	`33`	`+ private final boolean impersonationEnabled;`
`33`	`34`
`34`		`- public HiveMetastoreModule(Optional<HiveMetastore> metastore)`
	`35`	`+ public HiveMetastoreModule(Optional<HiveMetastore> metastore, boolean impersonationEnabled)`
`35`	`36`	`{`
`36`	`37`	`this.metastore = metastore;`
	`38`	`+ this.impersonationEnabled = impersonationEnabled;`
`37`	`39`	`}`
`38`	`40`
`39`	`41`	`@Override`
`40`	`42`	`protected void setup(Binder binder)`
`41`	`43`	`{`
`42`	`44`	`if (metastore.isPresent()) {`
`43`		`- binder.bind(HiveMetastoreFactory.class).annotatedWith(RawHiveMetastoreFactory.class).toInstance(HiveMetastoreFactory.ofInstance(metastore.get()));`
	`45`	`+ binder.bind(HiveMetastoreFactory.class).annotatedWith(RawHiveMetastoreFactory.class).toInstance(HiveMetastoreFactory.ofInstance(metastore.get(), impersonationEnabled));`
`44`	`46`	`binder.bind(Key.get(boolean.class, AllowHiveTableRename.class)).toInstance(true);`
`45`	`47`	`}`
`46`	`48`	`else {`
Original file line number	Diff line number	Diff line change
`@@ -38,17 +38,23 @@ public class TestingHiveConnectorFactory`
`38`	`38`	`implements ConnectorFactory`
`39`	`39`	`{`
`40`	`40`	`private final Optional<HiveMetastore> metastore;`
	`41`	`+ private final boolean metastoreImpersonationEnabled;`
`41`	`42`	`private final Module module;`
`42`	`43`
`43`	`44`	`public TestingHiveConnectorFactory(Path localFileSystemRootPath)`
`44`	`45`	`{`
`45`		`- this(localFileSystemRootPath, Optional.empty(), Optional.empty());`
	`46`	`+ this(localFileSystemRootPath, Optional.empty(), false, Optional.empty());`
`46`	`47`	`}`
`47`	`48`
`48`	`49`	`@Deprecated`
`49`		`- public TestingHiveConnectorFactory(Path localFileSystemRootPath, Optional<HiveMetastore> metastore, Optional<DecryptionKeyRetriever> decryptionKeyRetriever)`
	`50`	`+ public TestingHiveConnectorFactory(`
	`51`	`+ Path localFileSystemRootPath,`
	`52`	`+ Optional<HiveMetastore> metastore,`
	`53`	`+ boolean metastoreImpersonationEnabled,`
	`54`	`+ Optional<DecryptionKeyRetriever> decryptionKeyRetriever)`
`50`	`55`	`{`
`51`	`56`	`this.metastore = requireNonNull(metastore, "metastore is null");`
	`57`	`+ this.metastoreImpersonationEnabled = metastoreImpersonationEnabled;`
`52`	`58`
`53`	`59`	`boolean ignored = localFileSystemRootPath.toFile().mkdirs();`
`54`	`60`	`this.module = binder -> {`
`@@ -79,6 +85,6 @@ public Connector create(String catalogName, Map<String, String> config, Connecto`
`79`	`85`	`if (metastore.isEmpty() && !config.containsKey("hive.metastore")) {`
`80`	`86`	`configBuilder.put("hive.metastore", "file");`
`81`	`87`	`}`
`82`		`- return createConnector(catalogName, configBuilder.buildOrThrow(), context, module, metastore, Optional.empty());`
	`88`	`+ return createConnector(catalogName, configBuilder.buildOrThrow(), context, module, metastore, metastoreImpersonationEnabled, Optional.empty());`
`83`	`89`	`}`
`84`	`90`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,30 +29,36 @@ public class TestingHivePlugin`
`29`	`29`	`{`
`30`	`30`	`private final Path localFileSystemRootPath;`
`31`	`31`	`private final Optional<HiveMetastore> metastore;`
	`32`	`+ private final boolean metastoreImpersonationEnabled;`
`32`	`33`	`private final Optional<DecryptionKeyRetriever> decryptionKeyRetriever;`
`33`	`34`
`34`	`35`	`public TestingHivePlugin(Path localFileSystemRootPath)`
`35`	`36`	`{`
`36`		`- this(localFileSystemRootPath, Optional.empty(), Optional.empty());`
	`37`	`+ this(localFileSystemRootPath, Optional.empty(), false, Optional.empty());`
`37`	`38`	`}`
`38`	`39`
`39`	`40`	`@Deprecated`
`40`	`41`	`public TestingHivePlugin(Path localFileSystemRootPath, HiveMetastore metastore)`
`41`	`42`	`{`
`42`		`- this(localFileSystemRootPath, Optional.of(metastore), Optional.empty());`
	`43`	`+ this(localFileSystemRootPath, Optional.of(metastore), false, Optional.empty());`
`43`	`44`	`}`
`44`	`45`
`45`	`46`	`@Deprecated`
`46`		`- public TestingHivePlugin(Path localFileSystemRootPath, Optional<HiveMetastore> metastore, Optional<DecryptionKeyRetriever> decryptionKeyRetriever)`
	`47`	`+ public TestingHivePlugin(`
	`48`	`+ Path localFileSystemRootPath,`
	`49`	`+ Optional<HiveMetastore> metastore,`
	`50`	`+ boolean metastoreImpersonationEnabled,`
	`51`	`+ Optional<DecryptionKeyRetriever> decryptionKeyRetriever)`
`47`	`52`	`{`
`48`	`53`	`this.localFileSystemRootPath = requireNonNull(localFileSystemRootPath, "localFileSystemRootPath is null");`
`49`	`54`	`this.metastore = requireNonNull(metastore, "metastore is null");`
	`55`	`+ this.metastoreImpersonationEnabled = metastoreImpersonationEnabled;`
`50`	`56`	`this.decryptionKeyRetriever = requireNonNull(decryptionKeyRetriever, "decryptionKeyRetriever is null");`
`51`	`57`	`}`
`52`	`58`
`53`	`59`	`@Override`
`54`	`60`	`public Iterable<ConnectorFactory> getConnectorFactories()`
`55`	`61`	`{`
`56`		`- return ImmutableList.of(new TestingHiveConnectorFactory(localFileSystemRootPath, metastore, decryptionKeyRetriever));`
	`62`	`+ return ImmutableList.of(new TestingHiveConnectorFactory(localFileSystemRootPath, metastore, metastoreImpersonationEnabled, decryptionKeyRetriever));`
`57`	`63`	`}`
`58`	`64`	`}`