From b125fe868f95b67720e6fa90efc3fec981c297b7 Mon Sep 17 00:00:00 2001 From: Gaetan Covelli <gaetan.covelli@trivago.com> Date: Mon, 22 Jul 2019 09:39:16 +0200 Subject: [PATCH 1/2] Removes prefetch for async components --- .../melody-plugin-idom/src/visitors/mount.js | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/packages/melody-plugin-idom/src/visitors/mount.js b/packages/melody-plugin-idom/src/visitors/mount.js index 3dc6f02..87e7596 100644 --- a/packages/melody-plugin-idom/src/visitors/mount.js +++ b/packages/melody-plugin-idom/src/visitors/mount.js @@ -108,24 +108,8 @@ export default { } if (isAsync) { - /* webpackPrefetch: true */ const source = path.node.source; - source.leadingComments = [ - { - type: 'CommentBlock', - value: ` ${[ - path.get('key').is('StringLiteral') - ? `webpackChunkName: "${ - args[args.length - 1].value - }"` - : '', - 'webpackPrefetch: true', - ] - .filter(Boolean) - .join(', ')} `, - }, - ]; const argument = [ t.objectProperty( t.identifier('promisedComponent'), From 6ab0493a633ce4ccc203b6439916c6dfcebf1593 Mon Sep 17 00:00:00 2001 From: Gaetan Covelli <gaetan.covelli@trivago.com> Date: Mon, 22 Jul 2019 10:51:35 +0200 Subject: [PATCH 2/2] Updates changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3d1f6d4..11e28f2 100755 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ ## master - Do not log warning for component first emission in `melody-streams` in production [#128](https://github.com/trivago/melody/pull/128) +- Remove prefetch for async components [#130](https://github.com/trivago/melody/pull/130) ## 1.2.0