Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider identifier #3

Open
7krasov opened this issue Dec 15, 2016 · 1 comment
Open

Slider identifier #3

7krasov opened this issue Dec 15, 2016 · 1 comment

Comments

@7krasov
Copy link

7krasov commented Dec 15, 2016

Hello, guys :-) It will be great if we can have 'slider_code' field on slider edit page.
Problem: At the moment slider_id is an unique field, which is generated automatically. (two different databases can have different slider_id). And if we use such code

echo $this->getLayout()->createBlock("Trive\Revo\Block\Slider\Items")->setSliderId(1)->toHtml();
We can have an error on different site instances.

If code setSliderId(1) works for one site instance, it can not to work for another:

server1.com : slider_id = 1
server2.com : slider_id = 2 (imagine, you've deleted slider_id=1 and can't use it anymore)

And if we have slider_code="homepage_slider", it will work everywhere and not depend on slider_id

Thanks

@chombe
Copy link
Contributor

chombe commented Dec 19, 2016

Hi @7krasov
great catch...

Something like "Identifier" field on CMS blocks, got it...
Thank you again for your feedback and suggestion...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants