Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich FullNode command-line-options #6218

Open
halibobo1205 opened this issue Feb 26, 2025 · 5 comments
Open

Enrich FullNode command-line-options #6218

halibobo1205 opened this issue Feb 26, 2025 · 5 comments

Comments

@halibobo1205
Copy link
Contributor

Background

Currently, the main service JARs in Java-Tron primarily include FullNode.jar and SolidityNode.jar. FullNode.jar supports three types of nodes: SR Node, FullNode, and LightFullNode. SolidityNode is not supported, but it is recommended that it be supported.

JAR Description
FullNode.jar full node, which is capable of creating and broadcasting transactions, synchronizing and broadcasting blocks
SolidityNode.jar solidity node, is capable of synchronizing solidified blocks from trusted nodes, can neither create nor broadcast transactions nor can it broadcast blocks.

Rationale

Why should this feature exist?

To enrich FullNode command-line options, support SolidityNode, merge FullNode.jar and SolidityNode.jar.

Specification

Merge SolidityNode.jar into FullNode.jar, and start it via java -jar FullNode.jar --solidity

Scope Of Impact

  1. Build process: SolidityNode.jar will no longer be built anymore.
  2. Tool usage: FullNode.jar will support the --solidity command.
@halibobo1205
Copy link
Contributor Author

Other command support, is welcome to talk about it.

@halibobo1205 halibobo1205 moved this to Ready in java-tron Feb 26, 2025
@GrothenDI
Copy link

Good idea.
I hava a question, was the initial reason for creating a separate soliditynode.jar due to technical limitations?

@angrynurd
Copy link

I want to confirm: Is this feature simply removing the previously compiled solidity.jar and replacing it with Fullnode.jar to assume its functionality, while keeping all logic of the solidity node/fullnode unchanged?

@halibobo1205
Copy link
Contributor Author

@angrynurd, yes, keep all logic of the solidity node/full node unchanged.

@halibobo1205
Copy link
Contributor Author

@GrothenDI, The previous reason may be unknown, but for now, there are no technical problems in using FullNode.jar to replace solidity.jar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready
Development

No branches or pull requests

3 participants