Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure integration tests cover nrepl startup #186

Open
trptcolin opened this issue Oct 1, 2018 · 1 comment
Open

Ensure integration tests cover nrepl startup #186

trptcolin opened this issue Oct 1, 2018 · 1 comment

Comments

@trptcolin
Copy link
Owner

In a recent change, lein trampoline run failed, but the test suite didn't catch it (😿) because the nrepl integration spec currently attaches to an nREPL server that's spun up in setup, then uses :attach.

This leaves the nrepl integration under-exercised by tests, which is now an issue due to the more active development and potential breaking changes there.

I'd be happy with another few tests like the existing ones, but run without the :attach assumption, where the server can be spun up inline. If necessary (due to port assumptions, TravisCI, or whatever), they could be done in a bash script instead of in clojure-land.

This was referenced Oct 1, 2018
@bbatsov
Copy link
Collaborator

bbatsov commented Oct 14, 2018

@trptcolin Do you need any help with that? I thought that it was going to be enough just to remove the deref.

I'm asking because a few users mentioned that now they get:

java.lang.Exception: No namespace: reply.eval-modes.nrepl found

which is this problem, so I'd like to fix this in REPL-y and update the dep in Boot and Lein.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants