From 8da5ed7c46ff3b543fa6557d37d8b11c539f06b3 Mon Sep 17 00:00:00 2001 From: Yu Ishikawa Date: Mon, 15 Apr 2024 21:00:14 +0900 Subject: [PATCH 1/2] Not suggest terrascan terrascan is no longer actively maintained. So, it would be good not to suggest if related files exist. --- linters/terrascan/plugin.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linters/terrascan/plugin.yaml b/linters/terrascan/plugin.yaml index b11b9db38..11746ae0a 100644 --- a/linters/terrascan/plugin.yaml +++ b/linters/terrascan/plugin.yaml @@ -22,7 +22,7 @@ lint: - name: terrascan tools: [terrascan] known_good_version: 1.18.1 - suggest_if: files_present + suggest_if: never commands: - name: lint output: sarif From 48d7abc7e2ec2f22ae8522efb22c46682e6d820d Mon Sep 17 00:00:00 2001 From: Tyler Jang Date: Tue, 23 Apr 2024 14:07:36 -0700 Subject: [PATCH 2/2] cleanup tests and comment --- linters/terrascan/plugin.yaml | 1 + tests/repo_tests/config_check.test.ts | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/linters/terrascan/plugin.yaml b/linters/terrascan/plugin.yaml index 11746ae0a..e166ee074 100644 --- a/linters/terrascan/plugin.yaml +++ b/linters/terrascan/plugin.yaml @@ -22,6 +22,7 @@ lint: - name: terrascan tools: [terrascan] known_good_version: 1.18.1 + # terrascan does not support some modern terraform syntax. Don't auto-recommend. suggest_if: never commands: - name: lint diff --git a/tests/repo_tests/config_check.test.ts b/tests/repo_tests/config_check.test.ts index 725f97f95..d2b964c96 100644 --- a/tests/repo_tests/config_check.test.ts +++ b/tests/repo_tests/config_check.test.ts @@ -165,7 +165,6 @@ describe("Global config health check", () => { "shfmt", "svgo", "taplo", - "terrascan", "tflint", "trivy", "trufflehog",