Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test forwarding #787

Merged
merged 4 commits into from
May 23, 2024
Merged

Fix flaky test forwarding #787

merged 4 commits into from
May 23, 2024

Conversation

TylerJang27
Copy link
Collaborator

@TylerJang27 TylerJang27 commented May 23, 2024

  1. Remove the repo_tests uploading since it was broken and not necessary anyway (the only way it would fail incorrectly is due to a significant runner issue).
  2. Coalesce KnownGoodVersion into Snapshots so that main and PRs use the same test name for "stable" (as opposed to Latest). This better normalizes this dimension of test variation.

Demonstration of correct naming (see comment below)

Copy link

trunk-io bot commented May 23, 2024

⏱️ 19m total CI duration on this PR
Job Cumulative Duration Recent Runs
CodeQL-Build 5m 🟩🟩🟩
Repo Tests / Plugin Tests 4m 🟩🟩🟩
Windows Linter Tests 4m 🟥
Trunk Check runner [linux] 3m 🟩🟩🟩
Linter Tests ubuntu-latest 2m 🟥
Linter Tests macOS 2m 🟥
Detect changed files 32s 🟩🟩🟩
Aggregate Test Results 8s 🟩🟥🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link

trunk-staging-io bot commented May 23, 2024

💊 0 quarantined ✅ 0 passed 🕐 2 new ⋅ (learn more)

❌ 2 failed tests status
Testing linter yamllint Linux main Snapshots > Testing linter yamllint test basic
Testing linter yamllint Linux main Latest > Testing linter yamllint test basic

docs ⋅ learn more about trunk.io

@TylerJang27 TylerJang27 marked this pull request as ready for review May 23, 2024 17:30
@TylerJang27 TylerJang27 requested review from det and gnalh May 23, 2024 17:30
@TylerJang27 TylerJang27 merged commit 7e583c8 into main May 23, 2024
13 checks passed
@TylerJang27 TylerJang27 deleted the tyler/fine-tune-flaky branch May 23, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants