Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feat): Add support for squawk #858

Merged
merged 7 commits into from
Sep 10, 2024
Merged

(Feat): Add support for squawk #858

merged 7 commits into from
Sep 10, 2024

Conversation

TylerJang27
Copy link
Collaborator

@TylerJang27 TylerJang27 commented Aug 30, 2024

Adds squawk, a linter for Postgres migrations. Fixes #857. See note there about line number issues. Special thanks to @fnimick for getting this started.

I tried this out on our migration files and it raised a lot of issues, particularly about indexes. Without spending too long, I'm not sure how important those issues are, but I think it's better that this is a suggest_if: config_present for the near future. The relevant code owner should do an audit of the issues and config tuning.

Copy link

trunk-io bot commented Aug 30, 2024

⏱️ 1h 17m total CI duration on this PR
Job Cumulative Duration Recent Runs
Linter Tests ubuntu-latest 47m 🟩🟥🟥
Linter Tests macOS 20m 🟩🟩
Windows Linter Tests 3m 🟥
Trunk Check runner [linux] 3m 🟩
CodeQL-Build 2m 🟩
Repo Tests / Plugin Tests 30s 🟩
Aggregate Test Results 11s 🟩🟥🟥🟥
Detect changed files 4s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@TylerJang27
Copy link
Collaborator Author

TylerJang27 commented Aug 30, 2024

Pending full Windows support or a response from sbdchd/squawk#374

If we don't hear anything by the end of the week I'll just disable on Windows.

@TylerJang27 TylerJang27 requested review from det and puzzler7 September 3, 2024 18:46
Copy link
Member

@EliSchleifer EliSchleifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

trunk-staging-io bot commented Sep 9, 2024

✅ 481 passed ⋅ (learn more)

❌ 1 failed tests status
Testing linter terrascan Linux main KnownGoodVersion > Testing linter terrascan test basic

settingsdocs ⋅ learn more about trunk.io

@TylerJang27
Copy link
Collaborator Author

Windows appears to still have some additional issues. Will investigate early this week

@TylerJang27 TylerJang27 marked this pull request as ready for review September 10, 2024 23:32
@TylerJang27 TylerJang27 merged commit a7e3b46 into main Sep 10, 2024
15 checks passed
@TylerJang27 TylerJang27 deleted the tyler/support-squawk branch September 10, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

New linter request: squawk
2 participants