Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple tweak greatly improves header readability #162

Open
MrPeteH opened this issue Mar 31, 2023 · 2 comments
Open

Simple tweak greatly improves header readability #162

MrPeteH opened this issue Mar 31, 2023 · 2 comments

Comments

@MrPeteH
Copy link

MrPeteH commented Mar 31, 2023

It sure would be nice if this tiny tweak could be installed. I've been examining ARC headers till my brain melts down... this would make it much easier for all humans ;)

It simply places each authentication result at the start of a header sub-line, ie

ARC-Authentication-Results: .....
         dkim=pass .....;
         ...

That's how some of the Major Sites (I'm sure with their own modules) do it.
@andreasschulze what do you think? (I'm using your plugin version. Working well for me, with appropriate config...)

--- openarc.c   2023-03-31 22:30:09.772713338 +0000
***************
*** 3566,3572 ****
                                        }
  
                                        if (n != ar.ares_count - 1)
!                                               arcf_dstring_cat(afc->mctx_tmpstr, "; ");
                                }
                        }
                }
--- 3566,3572 ----
                                        }
  
                                        if (n != ar.ares_count - 1)
!                                               arcf_dstring_cat(afc->mctx_tmpstr, ";\n\t");
                                }
                        }
                }
@andreasschulze
Copy link

andreasschulze commented Apr 1, 2023

@MrPeteH what do you mean with "your plugin version" ?

the line numbers above let me think you refer this code in branch 'master'. Is this correct?

@MrPeteH
Copy link
Author

MrPeteH commented Apr 1, 2023

@andreasschulze I am almost certainly using improper vocabulary.
It's this code in branch 'master' of the andreasschulze fork, which is what I've been using and looking at ;) -- Same line, same file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants