Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lua final policy script functions may not work as expected #213

Open
branciar opened this issue Apr 5, 2024 · 0 comments
Open

Lua final policy script functions may not work as expected #213

branciar opened this issue Apr 5, 2024 · 0 comments

Comments

@branciar
Copy link

branciar commented Apr 5, 2024

The Lua final policy script functions odkim.add_rcpt, odkim.del_rcpt, odkim.del_header and odkim.quarantine need specific Milter capability flags to be set, respectivley SMFIF_ADDRCPT, SMFIF_DELRCPT, SMFIF_CHGHDRS and SMFIF_QUARANTINE.

However these flags are set only if specific configuration parameters are used. For example, SMFIF_ADDRCPT and SMFIF_DELRCPT are set only if RedirectFailuresTo is defined.

This leads to situations where the affected Lua functions are unusable.

#211 fixes this by enforcing SMFIF_ADDRCPT, SMFIF_DELRCPT, SMFIF_CHGHDRS and SMFIF_QUARANTINE if FinalPolicyScript is defined.
futatuki added a commit to futatuki/OpenDKIM that referenced this issue Apr 9, 2024
@futatuki
Merge pull request trusteddomainproject#213 from branciar/lua_delhead…
4bdd918 
…er_fix

Fix issue trusteddomainproject#191
futatuki added a commit to futatuki/OpenDKIM that referenced this issue Apr 9, 2024
@futatuki
Merge pull request trusteddomainproject#211 from branciar/lua_fixes
f0ed577 
Fix issue trusteddomainproject#213
futatuki added a commit to futatuki/OpenDKIM that referenced this issue Apr 26, 2024
@futatuki
Merge pull request trusteddomainproject#213 from branciar/lua_delhead…
8a5a9da 
…er_fix

Fix issue trusteddomainproject#191: make opendkim.del_header function honor header number.
futatuki added a commit to futatuki/OpenDKIM that referenced this issue Apr 26, 2024
@futatuki
Merge pull request trusteddomainproject#211 from branciar/lua_fixes
6c3817b 
Fix issue trusteddomainproject#213: Enforces activation of SMFIF_ADDRCPT,
SMFIF_DELRCPT, SMFIF_CHGHDRS and SMFIF_QUARANTINE capabilities
if FinalPolicyScript is defined in opendkim.conf, so that the
LUA final policy script functions odkim.add_rcpt, odkim.del_rcpt,
odkim.del_header and odkim.quarantine actually work regardless of
other configuration parameters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@branciar