Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Jettons on TON blockchain #3898

Open
snowkidind opened this issue Jun 14, 2024 · 13 comments
Open

Support for Jettons on TON blockchain #3898

snowkidind opened this issue Jun 14, 2024 · 13 comments

Comments

@snowkidind
Copy link

Gentlemen thanks for supporting TON, there are many wallets on the TON ecosystem that use a 24 word mnemonic but none that use a 12 word.

Further, the method you used to generate the wallet is unknown, and because of this the wallet address you derived from your keygen method does not support Jettons. This becomes an issue when a TON user decides to send Jettons to the TON address the trust wallet generates.

Another wallet has added an import from private key feature to their wallet but alas, the common method is not being used in trust causing peoples funds (like JUSDT) to be lost in the mix.

Can you at a minimum devolve the method you used to create the twelve word mnemonic or create an escape path for mistakenly sent jettons to a trust wallet?

Thanks

See Also:
mytonwalletorg/mytonwallet#62

@ronaldoguedess
Copy link

ronaldoguedess commented Jun 15, 2024

Do you mean that the Trust Wallet method doesn't support Jettons? There is a method in their examples; I think it works. However, the seed generated by Trust Wallet is not compatible with TON's wallets. Nevertheless, it's still possible to import using the private key.

Soon I will be launching the TON Network on the ECOIN Wallet, where you will be able to use the private key as well as 12 or 24 words.
Image

@snowkidind
Copy link
Author

snowkidind commented Jun 15, 2024

I dont believe trust wallet supports jettons, unless it's recent.

Access to jettons via whatever method they used to derive a private key / address in trust wallet is not currently possible using any known methods for example, using

      const provider = tonweb.provider
      const seed = await mnemonicToSeed([mnemonic]) // 12 word mnemonic
      const keyPair = tonweb.utils.nacl.sign.keyPair.fromSeed(seed)

      const wallet = new tonweb.wallet.all.v4R2(provider, {
        publicKey: keyPair.publicKey,
        wc: 0
      })

      console.log(keyPair.secretKey.toString()) // private key doesnt generate the trust wallet address shown in wallet

@ronaldoguedess
Copy link

The Trust Wallet core supports this, but the Trust Wallet App does not. As I mentioned earlier, the ECOIN Wallet will soon introduce TON Network, with support for private keys, a 12-word, or 24-word seed phrase, and also Jettons.

@snowkidind
Copy link
Author

bro stop spamming the githubs this is not an appropriate channel

@ronaldoguedess
Copy link

ronaldoguedess commented Jun 15, 2024

bro stop spamming the githubs this is not an appropriate channel

I understand your frustration. I just said I will launch what you need to solve your problem, and I apologize if my approach seemed spammy.

@snowkidind
Copy link
Author

developer community can read the instructions, we dont need to be battered by repeat information. please consider this moving forward.

@Milerius
Copy link
Collaborator

Milerius commented Jun 15, 2024

Hello, we will begin the development of Ton Jettons in TrustWallet App next week, and will also add Ton Connect.

In terms of wallet compatibility, it's important to remember that TrustWallet is a multichain wallet that relies on the widely used standards for generating seed and private keys: BIP39 and BIP44. Regrettably, the Ton architecture has adopted a different approach that we cannot support without compromising compatibility for our users. Nevertheless, it will still be possible to import the private key, and you should be able to see your Ton Jettons within the next weeks. Additionally, you'll be able to access Ton Ecosystem DApps directly within the TrustWallet app.

@ronaldoguedess
Copy link

Read about the seed: #3188

@Milerius
Copy link
Collaborator

Read about the seed: #3188

We understand the request, and to ensure complete transparency, incorporating this into the app for smooth user experience would necessitate significant rework and architectural design changes. This is specifically to support a single blockchain with a unique seed generation method. While we're not ruling it out, it's not an update you can expect in the near future.

@ronaldoguedess
Copy link

Hello, we will begin the development of Ton Jettons in TrustWallet App next week, and will also add Ton Connect.

In terms of wallet compatibility, it's important to remember that TrustWallet is a multichain wallet that relies on the widely used standards for generating seed and private keys: BIP39 and BIP44. Regrettably, the Ton architecture has adopted a different approach that we cannot support without compromising compatibility for our users. Nevertheless, it will still be possible to import the private key, and you should be able to see your Ton Jettons within the next week. Additionally, you'll be able to access Ton Ecosystem DApps directly within the TrustWallet app.

That's great news! 👏🏻 You're absolutely correct; it could affect the compatibility for TW users. What's your plan regarding the Webprovider? Are you considering adding support for TON dapps on the Trust Web3 Provider (https://github.com/trustwallet/trust-web3-provider), or will you opt to implement Ton Connect (trustwallet/trust-web3-provider#529)?

Also, considering that TON Connect currently lacks a JAVA/KOTLIN library, are you planning to develop something to address this gap?

@Milerius
Copy link
Collaborator

Hello, we will begin the development of Ton Jettons in TrustWallet App next week, and will also add Ton Connect.
In terms of wallet compatibility, it's important to remember that TrustWallet is a multichain wallet that relies on the widely used standards for generating seed and private keys: BIP39 and BIP44. Regrettably, the Ton architecture has adopted a different approach that we cannot support without compromising compatibility for our users. Nevertheless, it will still be possible to import the private key, and you should be able to see your Ton Jettons within the next week. Additionally, you'll be able to access Ton Ecosystem DApps directly within the TrustWallet app.

That's great news! 👏🏻 You're absolutely correct; it could affect the compatibility for TW users. What's your plan regarding the Webprovider? Are you considering adding support for TON dapps on the Trust Web3 Provider (https://github.com/trustwallet/trust-web3-provider), or will you opt to implement Ton Connect (trustwallet/trust-web3-provider#529)?

Also, considering that TON Connect currently lacks a JAVA/KOTLIN library, are you planning to develop something to address this gap?

Those choice(s) will be made by @y3fers0n & @gastonm5 who are leading this initative.

@ffrediani
Copy link

@Milerius would you comment about this issue regarding derivation path that seems to be different in TrustWallet ? I guess this would have no issues regarding compromising compatibility for our users. It would be just a choice to be made like other wallets did and be the same so an user importing their words into either wallet funds will appear as expected.

If is necessary a significant architectural changes than so be it. At the end at the user's benefit to have a more seamless app for their choice and not have to worry about details like derivation path, private key etc.

Importing the private key is always something undesirable because it needs further steps to get this information and it is not as friendly as importing 12 or 24 words. It can be a temporary solution, but not definitive.

Good to see there is work going on this topic by TW Team.

@Doferesouleymane
Copy link

Cool@285

@trustwallet trustwallet deleted a comment from Moormemar Jun 27, 2024
@trustwallet trustwallet deleted a comment from Moormemar Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants