Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to journey info table #639

Open
hathix opened this issue Apr 30, 2020 · 4 comments · May be fixed by #644
Open

Improvements to journey info table #639

hathix opened this issue Apr 30, 2020 · 4 comments · May be fixed by #644
Assignees
Labels
Frontend React, JavaScript, and UI stuff UX User Experience

Comments

@hathix
Copy link
Member

hathix commented Apr 30, 2020

I was viewing this route comparison:

image

Thoughts:

  • Isn't it a bad thing for on-time rate to go down 20%? In that case, shouldn't the text be orange/red instead of green?
  • The completed trips metric isn't all that useful, since the date ranges are different lengths. "Completed trips per day" for multiple-day routes would be ideal.
  • For Median Wait Time, I'd rather see it called "even" rather than not having a label at all.
@hathix hathix added Frontend React, JavaScript, and UI stuff UX User Experience labels Apr 30, 2020
@hathix
Copy link
Member Author

hathix commented Apr 30, 2020

I'm starting to work on this in the route-table branch. Others can run with this if I don't finish it quickly.

@hathix
Copy link
Member Author

hathix commented Apr 30, 2020

Update -- no need for "even" since nothing is truly equal. In my branch I'm just going to make it show "<1" if the difference is very small; currently that code path doesn't trigger.

But I did fix the on-time rate coloring issue. The completed trips metric might be big enough to deserve its own PR.

@hathix hathix self-assigned this Apr 30, 2020
@hathix
Copy link
Member Author

hathix commented Apr 30, 2020

@hathix
Copy link
Member Author

hathix commented May 7, 2020

The completed trips bit is hard. You'd have to do it per hour for it to really be valuable.

@hathix hathix linked a pull request May 7, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend React, JavaScript, and UI stuff UX User Experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant