Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3 correction of missing leading zeros on all elements of sexagesimal units #4

Closed
wants to merge 6 commits into from

Conversation

Republicof1
Copy link
Contributor

correction and better tests to identify incorrect numbers of zeros

pahjbo and others added 2 commits September 27, 2024 10:05
DMS and HMS fixed to pad zeros
Library structure changed for improved readability
@Republicof1 Republicof1 linked an issue Oct 2, 2024 that may be closed by this pull request
also correct the path for the documentation generation
Copy link
Member

@pahjbo pahjbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using https://typedoc.org/guides/doccomments/ for documentation generation, so the comment style should be changed to match that - you can run the doc creation with
npm run doc

@pahjbo pahjbo linked an issue Oct 3, 2024 that may be closed by this pull request
@pahjbo
Copy link
Member

pahjbo commented Oct 14, 2024

closing this as #5 has all these changes now

@pahjbo pahjbo closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sexagesimal fields should be two characters wide sexagesimal conversion not accurate enough
2 participants