Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mock-fs@3 broken in node.js 6.10.1+ and 7.7.0+ #203

Open
papandreou opened this issue Apr 11, 2017 · 2 comments
Open

mock-fs@3 broken in node.js 6.10.1+ and 7.7.0+ #203

papandreou opened this issue Apr 11, 2017 · 2 comments

Comments

@papandreou
Copy link

Ran into this error with mock-fs 3.12.1, the latest 3.x release: https://travis-ci.org/papandreou/fileception/jobs/220931111#L600-L610

It happens with node.js 6.10.1+ (but not 6.10.0) and 7.7.0 (but not 7.6.0).

The most likely culprit is https://github.com/nodejs/node/pull/11522/files, which was the only fs-related change to land in both releases.

Tried a naive fix that makes the problem go away, but seems to cause problems elsewhere.

I can't upgrade to mock-fs@4 for now because of require('mock-fs').fs being removed.

@Slayer95
Copy link

I forked v3 as mock-fs-require-fix a while back in order to get #145 fixed. I have just added support of the newest Node v6 and v7 releases.

papandreou added a commit to papandreou/fileception that referenced this issue Apr 27, 2017
papandreou added a commit to unexpectedjs/unexpected-fs that referenced this issue Apr 27, 2017
@papandreou
Copy link
Author

@Slayer95, thanks a lot for doing that and letting me know. It seems to work great, and allowed me to fix the unexpected-fs and fileception modules in those new node.js 6 and 7 releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants