-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getting error on Android #54
Comments
|
I actually found the issue for my case. @tschoffelen are you interested in having the changes in your package? If so I can make a PR for the changes. |
Hi @adrienGzc! Good find! Definitely happy to accept PRs. One thing to keep in mind though is that I don't think that's a valid semver, so might also need to see if that causes problems with the version comparison logic. |
Let me check how this behaves, I'll let you know 🙂 |
If you're willing to open a PR with this change that would be amazing! |
"react-native-check-version": "^1.1.1",
"react-native": "0.66.5",
{ platform: 'android',
bundleId: 'com.tntmobile',
version: null,
needsUpdate: false,
notes: '',
url: null,
lastChecked: '2023-05-28T12:37:39.902Z',
country: 'fr',
error: [TypeError: Cannot convert null value to object] }
in node modules here is the issue
const text = await res.text();
const version = text.match(/[[['"['"]]],/)[1];
getting null while applying the regex
The text was updated successfully, but these errors were encountered: