Merge pull request #9 from MustafaMulla29/feat/ky

Switched to ky from redaxios

Author: MustafaMulla29

.github/workflows/bun-typecheck.yml

@@ -22,5 +22,8 @@ jobs:
       - name: Install dependencies
         run: bun i
 
+      - name: Build the project
+        run: bun run build
+
       - name: Run type check
         run: bunx tsc --noEmit

bun.lockb

@@ -6,8 +6,8 @@
     "@biomejs/biome": "^1.8.3",
     "@types/bun": "latest",
     "@types/react": "18.3.4",
-    "next": "^14.2.5",
-    "redaxios": "^0.5.1"
+    "ky": "^1.8.1",
+    "next": "^14.2.5"
   },
   "peerDependencies": {
     "typescript": "^5.0.0"

package.json

@@ -1,12 +1,12 @@
 import { afterEach } from "bun:test"
 import { tmpdir } from "node:os"
-import defaultAxios from "redaxios"
+import ky from "ky"
 import { startServer } from "./start-server"
 
 interface TestFixture {
   url: string
   server: any
-  axios: typeof defaultAxios
+  ky: typeof ky
 }
 
 export const getTestServer = async (): Promise<TestFixture> => {
@@ -20,8 +20,8 @@ export const getTestServer = async (): Promise<TestFixture> => {
   })
 
   const url = `http://127.0.0.1:${port}`
-  const axios = defaultAxios.create({
-    baseURL: url,
+  const kyInstance = ky.create({
+    prefixUrl: url,
   })
 
   afterEach(async () => {
@@ -32,6 +32,6 @@ export const getTestServer = async (): Promise<TestFixture> => {
   return {
     url,
     server,
-    axios,
+    ky: kyInstance,
   }
 }

tests/fixtures/get-test-server.ts

@@ -2,8 +2,9 @@ import { it, expect } from "bun:test"
 import { getTestServer } from "tests/fixtures/get-test-server"
 
 it("GET /health should return ok", async () => {
-  const { axios } = await getTestServer()
-  const res = await axios.get("/health")
+  const { ky } = await getTestServer()
+  const res = await ky.get("health")
   expect(res.status).toBe(200)
-  expect(res.data).toEqual({ ok: true })
+  const data = await res.json()
+  expect(data).toEqual({ ok: true })
 })

tests/routes/health.test.ts

@@ -2,14 +2,18 @@ import { getTestServer } from "tests/fixtures/get-test-server"
 import { test, expect } from "bun:test"
 
 test("create a thing", async () => {
-  const { axios } = await getTestServer()
+  const { ky } = await getTestServer()
 
-  axios.post("/things/create", {
-    name: "Thing1",
-    description: "Thing1 Description",
+  ky.post("things/create", {
+    json: {
+      name: "Thing1",
+      description: "Thing1 Description",
+    },
   })
 
-  const { data } = await axios.get("/things/list")
+  const data = await ky
+    .get("things/list")
+    .json<{ things: { name: string; description: string }[] }>()
 
   expect(data.things).toHaveLength(1)
 })