Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"strictest" includes non-typesafety relevant options #262

Closed
domdomegg opened this issue Apr 6, 2024 · 1 comment
Closed

"strictest" includes non-typesafety relevant options #262

domdomegg opened this issue Apr 6, 2024 · 1 comment

Comments

@domdomegg
Copy link

Going with the definition that strictest "automatically enables every TypeScript compiler flag that has to do with type checking, making it as strict as possible.", I think the following should be out of scope given that these do not detect type errors - and are more just general linting rules (i.e. violations of these alone will never lead to a runtime error):

  • allowUnreachableCode
  • allowUnusedLabels
  • noPropertyAccessFromIndexSignature
  • noUnusedLocals
  • noUnusedParameters

Also see #156. I think this is a separate discussion: that discussion foucses on build-related flags and logistics around how the configs are used. This issue relates to specific flags that aren't performing type checking.

--

Proposed solutions:

  • Removing these flags from strictest
  • Creating a new preset, maybe strictest-types which has all the type checking rules enabled (but not these extra rules about e.g. unused code)
@orta
Copy link
Member

orta commented Apr 6, 2024

No, I think these are the "strictest" version of TypeScript - you're welcome to a differing opinion but I don't think we need to make breaking changes to strict to remove the linter-ish properties only to eventually have to remake a version a bit like this.

@orta orta closed this as completed Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants