Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No push on finish #2

Open
virus2016 opened this issue Nov 1, 2018 · 6 comments
Open

No push on finish #2

virus2016 opened this issue Nov 1, 2018 · 6 comments

Comments

@virus2016
Copy link

Hi @Romakita,

Are we able not to push the production on finish as we have protected branches?

Thanks!

@Romakita
Copy link
Collaborator

Romakita commented Nov 1, 2018

Hello @virus2016,

Production branch is protected and you are only available to push the commits based on the origin/production. The only case where you are not able to push on origin/production, is the case when your local branch production is synchronized with origin/production.
On which repository you have the problem ?

@virus2016
Copy link
Author

We have a private repo.

The structure is:

Master (protected)
Develop (protected)

We usually PR into develop from branches created then develop into master. Do you think we should do it another way?

@Romakita
Copy link
Collaborator

Romakita commented Nov 6, 2018

The develop branch shouldn't be protected because, gflow tools try to reset develop (if syncAfterFinish is true).

@virus2016
Copy link
Author

Our develop branch must be in a working state so that a developer can run the project and base features from there which is why it is protected.

@virus2016
Copy link
Author

It would be brilliant if the finish command has an option not to merge to master and push.

@Romakita
Copy link
Collaborator

Romakita commented Nov 6, 2018

Ok in your case, just change the configuration by this:

{
  "production": "develop",
  "develop": "develop"
}

It avoid the merge on your production (master).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants