-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all valid countries both in english and greek language #71
Labels
good first issue
Good for newcomers
Comments
I'll handle this issue |
Hello there @Nikos-Katsafados , We can use all countries countries from ISO_3166-1. Below I'm proposing a JSON schema: {
"id": "004",
"name": "Afghanistan",
"officialName": "The Islamic Republic of Afghanistan",
"sovereignty": "UN member",
"iso31661": {
"A2": "AF",
"A3": "AFG"
},
"tld": ".af",
"independent": true
}, Finally I suggest the below 3 fns for implementation (of course feel free to further discuss them): getAllCountries({locale = "el" }) => Country[]
searchCountryByName({locale = "el", searchTerm: "greece" }) => Country[]
getCountryByType({locale = "el", type: "iso31661 | tld | id | etc....", value: "value" }) => Country best regards, |
All data imported thanks to @Nikos-Katsafados with this PR => #89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For start we can get all the available countries with the fn
getCountries({ locale: "el" })
;The text was updated successfully, but these errors were encountered: