Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To be a trap or not to be a trap #167

Open
Neb-RS opened this issue Mar 22, 2022 · 3 comments
Open

To be a trap or not to be a trap #167

Neb-RS opened this issue Mar 22, 2022 · 3 comments

Comments

@Neb-RS
Copy link
Contributor

Neb-RS commented Mar 22, 2022

The recent lower level update has changed some trap names again, which means that they are not correctly recognized by the tool. This is at least true for Interdimensional Crossbow (ingame, + trap in the tool) and Obelisk of Slumber and Obelisk of Incineration (+trap in game, not in the tool.

Instead of having to continuously check, it might be better to just remove the suffix if there is one in the game, so that the array doesn't have to be touched for cases like this.

@tsitu
Copy link
Owner

tsitu commented Mar 30, 2022

Hi Neb, great suggestion. I had considered implementing a suffix removal in the past, but can't remember if there was a specific reason why it wasn't implemented. I may have just ended up prioritizing other scripts/features.

If this is something you'd like to tackle moving forward I'd greatly appreciate it. I don't have much time nowadays to commit (heh) to this repo besides the occasional PR review and urgent maintenance.

@Neb-RS
Copy link
Contributor Author

Neb-RS commented Mar 30, 2022

I fear I don't have the coding skills for it (read: I don't have any). Unless there is something similar to it, then I could probably copy paste and edit it enough to get it to work.

@tsitu
Copy link
Owner

tsitu commented Mar 31, 2022

Never too late to start learning 😉 IMO this issue happens so infrequently that quick tweaks to arrays.js isn't really too big of a burden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants