You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ideally the populations file should use the system names for locations/phases. These are not always the best to display.
Investigation is required to create a generic mapping for system -> pretty name and falling back to the system name if it is not present. It can be defined in a csv or text file and integrated into the CI build if necessary.
Keeping the system names in the populations file keeps population updates simpler and minimizes the logic required in the CRE bookmarklet and during URL parsing.
This same type of mapping could potentially be used for any values that we retrieve from the bookmarklet/Jack's tools (eg. cheese, charms) since there are if statements that append and slice strings all over the place.
Ideally the populations file should use the system names for locations/phases. These are not always the best to display.
Investigation is required to create a generic mapping for system -> pretty name and falling back to the system name if it is not present. It can be defined in a csv or text file and integrated into the CI build if necessary.
Keeping the system names in the populations file keeps population updates simpler and minimizes the logic required in the CRE bookmarklet and during URL parsing.
See my comments on 821e417
The text was updated successfully, but these errors were encountered: