Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Logic for location/phase names #52

Open
Mistborn94 opened this issue Oct 26, 2017 · 1 comment
Open

Display Logic for location/phase names #52

Mistborn94 opened this issue Oct 26, 2017 · 1 comment

Comments

@Mistborn94
Copy link
Contributor

Mistborn94 commented Oct 26, 2017

Ideally the populations file should use the system names for locations/phases. These are not always the best to display.

Investigation is required to create a generic mapping for system -> pretty name and falling back to the system name if it is not present. It can be defined in a csv or text file and integrated into the CI build if necessary.

Keeping the system names in the populations file keeps population updates simpler and minimizes the logic required in the CRE bookmarklet and during URL parsing.

See my comments on 821e417

@Mistborn94
Copy link
Contributor Author

This same type of mapping could potentially be used for any values that we retrieve from the bookmarklet/Jack's tools (eg. cheese, charms) since there are if statements that append and slice strings all over the place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants