Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra parameter in DemographicEvent.get_ll_representation #1037

Open
jeromekelleher opened this issue May 24, 2020 · 2 comments
Open
Milestone

Comments

@jeromekelleher
Copy link
Member

We have an extra unused parameter in the get_ll_representation for each DemographicEvent class. This is needed because stdpopsim will uses this until msprime 1.0 is released. Stdpopsim should then transition to using the richer API from msprime instead of doing things locally.

popsim-consortium/stdpopsim#535

Once stdpopsim 0.2.0 has been released using this new API it should be safe to remove the unused parameters, as the stdpopsim usage is a development tool rather than something used directly in simulations.

See #1010

@jeromekelleher
Copy link
Member Author

Can you check if this can be done now @GertjanBisschop? If stdpopsim has been using msprime >= 1.0 for a while then I think we can clean this up.

@jeromekelleher
Copy link
Member Author

Adding to 1.3.1 milestone for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant