Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail with stdpopsim 0.2.0 #2233

Open
benjeffery opened this issue Dec 7, 2023 · 7 comments
Open

Tests fail with stdpopsim 0.2.0 #2233

benjeffery opened this issue Dec 7, 2023 · 7 comments

Comments

@benjeffery
Copy link
Member

benjeffery commented Dec 7, 2023

Looks like all other dep updates are good, but stdpopsim is failing:

AttributeError: 'DemographicModel' object has no attribute 'population_configurations'

@benjeffery benjeffery added this to the 1.3.0 milestone Dec 7, 2023
@GertjanBisschop
Copy link
Member

The tests that are failing are tests that are marked as temporary:
# This test is temporary while we are updating stdpopsim to use the msprime APIs. See the nodes in the _ooa_model() code.
I am not familiar with the details here. Is this simply a case of bumping up the dependency version and removing these temporary tests @jeromekelleher ?

@jeromekelleher
Copy link
Member

Yeah, let's bump the dependencey and nuke those tests. What do the notes in the _ooa_model code say?

@GertjanBisschop
Copy link
Member

Hmm, can't find the notes.

@jeromekelleher
Copy link
Member

Definitely delete then

@GertjanBisschop
Copy link
Member

Aha found it: thought the notes were in the stdpopsim code but they are in the msprime code instead:

"
This version is included here temporarily as a way to get some
test coverage on the model compared with stdpopsim. Because we
use this model in the documentation, we want make sure that it's
doing what we think. We compare the model defined here then with
the one presented in the docs, to ensure that no errors creep in.
Once the upstream code in stdpopsim is updated to use msprime 1.0
APIs we can remove this model and instead compare directly
to the stdpopsim model with .is_equivalent() or whatever.
"

@jeromekelleher
Copy link
Member

Hmm, this is annoying. The code has changed slightly in stdpopsim, so the tests of the demographic models don't quite line up any more. It will take a bit of fiddling to get these working again...

@jeromekelleher
Copy link
Member

Temporary workaround for release would be to pin stdpopsim back to previous version, and register an issue to track updating the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants