Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlighted section of source code is unreadable #173

Closed
connor-french opened this issue Mar 27, 2023 · 6 comments
Closed

highlighted section of source code is unreadable #173

connor-french opened this issue Mar 27, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@connor-french
Copy link

Hello all! I think the documentation site is fantastic and has helped me out quite a bit. Here's my issue:

There seems to be a problem with code highlighting when clicking on a [source] link for a particular function. The highlighted section in the source code turns pink and the underlying text is unreadable. I've attached a photo of what my screen looks like when I click [source] for the stepping_stone_model() function in the API References section.

Screen Shot 2023-03-27 at 2 40 01 PM

@jeromekelleher jeromekelleher added the bug Something isn't working label Mar 28, 2023
@jeromekelleher
Copy link
Member

Thanks for the bug report @connor-french! Is there anything we can do about this @benjeffery, or is a known issue on the queue for the next batch of website tweaks?

@benjeffery
Copy link
Member

This might be #131 but I'd need to check. I'll add this to the milestone.

@daikitag
Copy link
Contributor

I think this issue is already fixed in
tskit-dev/tskit-book-theme#5
but it is not uploaded to PyPI:

image

If I use tskit-book-theme in https://github.com/tskit-dev/tskit-book-theme locally on my computer, the highlighted section of source code looks perfectly fine. I think this issue will be easily solved if you could update the tskit-book-theme version in PyPI and recreate the website using the new tskit-book-theme.

image

@benjeffery
Copy link
Member

Thanks for the prod @daikitag! I do need to push an updated version on the package - maybe we should fix #151 first though?

@hyanwong
Copy link
Member

This is still a tiny bit garish on the newly updated site, but definitely readable, so I think we can close: Screenshot 2023-10-30 at 14 59 07

@benjeffery
Copy link
Member

Garish yes, but also the default for the offical theme - so I'm tempted to live with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants