Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy h5py based formats #2812

Open
benjeffery opened this issue Aug 3, 2023 · 5 comments
Open

Remove legacy h5py based formats #2812

benjeffery opened this issue Aug 3, 2023 · 5 comments
Milestone

Comments

@benjeffery
Copy link
Member

benjeffery commented Aug 3, 2023

Opening this up for discussion.

As mentioned by @jeromekelleher at #2811 (comment) it has been a long time since these legacy formats were used. When dropping them we should add a note in the docs to specify the version of tskit to use to upgrade the file.

@jeromekelleher
Copy link
Member

Agree. We should add a stable hyperlink on the tskit docs (Legacy HDF5 file formats) which we provide a link to in the error message also, so people know where to look when the file doesn't load.

@benjeffery benjeffery added this to the Python 0.5.5 milestone Aug 3, 2023
@molpopgen
Copy link
Member

I think we should do this ASAP. Definitely want to get it out of the way before any kind of 1.0 release is on the horizon.

@jeromekelleher
Copy link
Member

I might just go ahead and do this, we've got a bunch of PRs in flight and #2811 doesn't look like a quick fix. Any objections @benjeffery?

@benjeffery
Copy link
Member Author

#2811 needs to be done for lshmm anyway. So expediting this won't help. I should get #2811done today.

@jeromekelleher
Copy link
Member

Ah right, let's backburner so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants