Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary upwards traversals in tsk_pair_coalescence_stat #3047

Open
nspope opened this issue Nov 5, 2024 · 0 comments
Open

Avoid unnecessary upwards traversals in tsk_pair_coalescence_stat #3047

nspope opened this issue Nov 5, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@nspope
Copy link
Contributor

nspope commented Nov 5, 2024

tsk_pair_coalescence_stat propagates changes in sample counts/pair counts upwards to the root from edge insertions/deletions. However, if sample_sets is such that removing/adding a given edge has no impact on pair counts, there's no need to do the traversal to the roots. This should speed things up substantially when sample_sets is a small subset of the tree sequence.

@nspope nspope added the enhancement New feature or request label Nov 5, 2024
@nspope nspope self-assigned this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant