Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map mutations using Sankoff's algorithm #3071

Open
hyanwong opened this issue Dec 11, 2024 · 0 comments
Open

Map mutations using Sankoff's algorithm #3071

hyanwong opened this issue Dec 11, 2024 · 0 comments

Comments

@hyanwong
Copy link
Member

Not a priority, but a nice comp-sci student project. At the moment, the map_mutations code uses the Hartigan algorithm, in which all mutations are equally likely. The Sankoff algorithm is an equivalent one that allows mutations to be weighted, which would be useful when looking at e.g. transitions vs transversions, or mutations in viral sequences. @jeromekelleher cooked up an example implementation in #99 and it's also mentioned in

* use a general cost matrix, in which case we'll use the Sankoff algorithm. For
, but I can't find any GH issue, so I thought I should open one.

There's a good description in http://profs.scienze.univr.it/liptak/ALBioinfo/2013_2014/files/PhylogenetikSkript2009.pdf (sect 4.4, which comes immediately after a description of the Hartigan algorithm). We probably want to keep the old code too, as it has better scaling properties, I think. However, we could optional pass a mutation matrix in to map_mutations, and if it is present, switch to Sankoff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant