Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update population diagrams in demography tutorial #58

Open
gtsambos opened this issue Mar 29, 2021 · 3 comments
Open

Update population diagrams in demography tutorial #58

gtsambos opened this issue Mar 29, 2021 · 3 comments

Comments

@gtsambos
Copy link
Member

The labels of all diagrams need to be updated, and some new ones need to be made for admixture + divergence.

@hyanwong
Copy link
Member

hyanwong commented Jun 7, 2021

It would be really nice if we could somehow use all the effort that @grahamgower has put in to the demesdraw visualiser to create diagrams, instead of drawing them by hand. Graham: I'm assuming that diagrams such as those in the demography tutorial would be easy to show as "tubes"?

@grahamgower
Copy link
Member

That's absolutely doable. But maybe demesdraw is too quirky or lacks some desirable features? For example, it doesn't consider the migration rate value when drawing migrations -- all lines are equally thick. And the mgiration lines are drawn at random times, not at fixed time intervals.

@hyanwong
Copy link
Member

hyanwong commented Jun 7, 2021

The tut is thanks to @gtsambos , so I'll let her weigh in, but I thought it would be useful to point out the possibilities here. I guess she can take it up with you, @grahamgower , if there's additional functionality that would be helpful? I just really like the demesdraw stuff (and I think I should also note in my tskit viz tut PR that demesdraw exists).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants