-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An option to exclude files and directories implied by -r
(recurse) option
#1258
Comments
Can you attach an lnav debug log (run lnav with I did a quick test with a system I had on hand and since the files in |
@tstack
I have run the command
In my case the above command took some 3 minutes to finish loading files, and it is visible from the Additional info: System: Debian 12.5 bookworm lnav -V
|
Ah, I was testing with the v0.12+, lnav v0.11.1 is slow for me as well. Are you able to upgrade to either v0.12.1 or there is a beta for the v0.12.2 release: |
I have tested The only problem I spotted is
Sadly I don't practice installing software that is not from Debian's repo on my main machine but it's not a big deal, I wish newer version to be available in Debian's backports, is that possible? While the issue with loading speed is solved, I think the option to exclude files and directories with |
The backquote character is now used to focus on the breadcrumb bar. The change was mentioned in the NEWS.md file and is shown in the top-right after startup.
I don't maintain OS packages. You could try using the snap version, which I do maintain.
I think some other tools support more sophisticated glob patterns that allow you to write exclusions, I'll look into doing something like that. |
OK, you close this issue if no decision to implement option to exclude, for me this is solved. |
Sorry, but I'm not in love with this. On a Swedish keyboard that means pressing shift-' space, which is anything but intuitive and fast. |
@FaffeF can you recommend an alternative? I found ENTER to be too easy to press and was activating the bar when I didn’t want to. |
@FaffeF I didn't know this for a very long time until recently, you might as well find the key on your keyboard by trying out. @tstack And beside that pressing Or if it has to be single key, then |
I'm guessing the whole point of this is to use the "quake" key, i.e. the key to the left of 1. Checking different keyboard layouts, I see there are quite a few different symbols located there, where we in the Nordics seem to have settled on the section mark §, sorry @metablaster. A thought that occurred to me is that there may be some key people expect the menu bar to be available at, rather than backtick? F10 seems to be more or less standard in Windows applications. Alt+space also comes to mind. This is quite a similar issue to my old one #1066, and I could try to author another pull request. Mabye I could check the other available keymaps as well. And sorry for kidnapping the thread, this should be a separate issue. |
There's currently no command to focus on the breadcrumb bar, which is a gap. I think I'll add it as an option to the existing |
I've pushed a change that adds a lnav/src/keymaps/default-keymap.json Lines 174 to 177 in 99c6aab
I bound it to lnav/src/keymaps/sv-keymap.json Lines 27 to 30 in 99c6aab
At the moment, Note that in v0.12.2, you can also focus on the breadcrumbs using the mouse. That might help the situation a bit. Do you folks actually use the breadcrumb bar? I'm amazed that anyone actually cared enough to notice/speak up. If so, that's great! |
That's fine with me, it's quake key on my keyboard which is easy to press.
Certainly, it's very useful to set time how fast to scroll, to select different log formats etc. Overall no objections, but I'm new user so might me missing what ever gotchas. |
Seems to work with the Swedish keymap, though now lnav exits on backtick, not sure if that was intended? (10s to test, 15 min to figure out where to download the ci artifact... yeah, I'm a bit slow) |
Is your feature request related to a problem? Please describe.
Using
-r
option to recurse into directory will pick up all files and directories including those one might now want to load.A solid example is
lnav -r /var/log
which will also load/var/log/journal
logs but those are undesired to be loaded first becausejournal
is better piped tolnav
and secondly because it will significantly slow down loading of log files.And unless I'm wrong
journal
entries are nothing but duplicate of already present and loaded files from/var/log
Describe the solution you'd like
An option to exclude files and directories when
-r
option is usedDescribe alternatives you've considered
I'm not aware of any alternatives other than writing a long line of directories and files which to explicitly load.
If you know of a better method as a workaround please share!
Additional context
I think the option to exclude files or directories should not be limited to the use of the
-r
option because one might want to exclude certain files when not recursing.The text was updated successfully, but these errors were encountered: