Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put OFirehose example in documentation to show how to subclass Feed class #113

Open
moggers87 opened this issue Sep 27, 2014 · 3 comments
Open

Comments

@moggers87
Copy link
Collaborator

We already have everything needed to read off OFirehose, but it would be nice to provide users with a something that they can just call and get Note objects etc. out of it.

kabniel added a commit to tsyesika/p that referenced this issue Sep 28, 2014
@kabniel
Copy link
Collaborator

kabniel commented Sep 28, 2014

I cant see the full conversation about this on pump.io, but i assume we're just talking about loading the https://ofirehose.com/feed.json file into a Feed object?

I added a p firehose (why are you giggling?) command with code that could easily be added to PyPump instead

@moggers87
Copy link
Collaborator Author

That's a lot simpler than I was imagining - maybe we could add something similar to the documentation? (ha!)

@moggers87 moggers87 changed the title OFirehose support out of the box Put OFirehose example in documentation to show how to subclass Feed class Sep 28, 2014
@kabniel
Copy link
Collaborator

kabniel commented Sep 28, 2014

It's not a perfect solution as the ofirehose feed is more limited than the usual pump.io feeds and the class will have to be re-instantiated every time you want to get items from it, it could probably be improved by overriding a few more methods.
For the p firehose command it's good enough though as we only use it once for every time the command is run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants