Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling mRefreshLayout.finishRefreshing() does not finish animation if its too fast #5

Open
Arbitrary-T opened this issue Aug 15, 2015 · 3 comments

Comments

@Arbitrary-T
Copy link

For example if as soon as the user refreshes, and there is no data to update (for example no connection/website down etc...) the animation just keeps on going but you can still refresh again by pulling while its refreshing.

I solved this by using a handler and calling postdelayed with a delay of 1000ms this would finish the view's animation but its not ideal because of 1000ms delay.

@Arbitrary-T Arbitrary-T changed the title Calling mRefreshLayout.finishRefreshing() does not happen finish animation if its too fast Calling mRefreshLayout.finishRefreshing() does not finish animation if its too fast Aug 15, 2015
@SanthoshDhandapani
Copy link

Yes finish refreshing does not happens mostly, which spoils the stable usability. Please fix asap

samigehi added a commit to samigehi/CircleRefreshLayout that referenced this issue Nov 6, 2015
FIXED issue (Cannot draw back after Refreshing complete) 

tuesda#7
tuesda#5
@thesnowgoose
Copy link

I am still having exactly the same issue.

`refreshLayout = (CircleRefreshLayout) findViewById(R.id.refresh_layout);

    if (refreshLayout != null) {
        refreshLayout.setOnRefreshListener(new CircleRefreshLayout.OnCircleRefreshListener() {
            @Override
            public void completeRefresh() { }

            @Override
            public void refreshing() {
                buildNewsRequest(null);
            }
        });
    }

`
in "buildNewsRequest()" is where I am calling refreshLayout.finishRefreshing();
and the method is being called but the animation just keep playing if buildNewsRequest() ends to soon.

@xrnd
Copy link

xrnd commented Nov 17, 2016

Yes same here. My network call finishes sometimes in as less as 5 ms. Then I set mRefresh.finishRefreshing(); the animation still goes on and can not dismiss only. Please let me know the work around if anybody has already found it. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants