Skip to content
This repository has been archived by the owner on Mar 29, 2022. It is now read-only.

Context Manager for Python Bindings #127

Open
corepointer opened this issue Mar 22, 2020 · 1 comment · May be fixed by #131
Open

Context Manager for Python Bindings #127

corepointer opened this issue Mar 22, 2020 · 1 comment · May be fixed by #131

Comments

@corepointer
Copy link
Collaborator

I would prefer some other way to shutdown the server than shutdown. Fist of all a check is missing since we only start a subprocess if no SystemDS instance is running yet, secondly if we need a explicit shutdown it makes sense to also have an explicit start. As I have already suggested in my PR it would make sense to use a ContextManager (See https://book.pythontips.com/en/latest/context_managers.html). We should make sure that we are happy with our decision since it will likely stay for longer, I hoped that we find a way to automatically shutdown the java server process on exit of the python program, but a ContextManager would also be a good idea.

Originally posted by @kev-inn in #125 (comment)

@corepointer
Copy link
Collaborator Author

A context manager sounds like a good idea. For now, the manual shutdown makes the python tests run, so we leave this here as an open issue.

@kev-inn kev-inn linked a pull request Mar 23, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant