Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic in generate.rb to make all the generated code private #2

Open
pepicrft opened this issue Jan 9, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@pepicrft
Copy link
Collaborator

pepicrft commented Jan 9, 2023

We have a generate script that uses swift-bridge to generate the Swift package from the Rust code. This package makes everything public by default leaking internal Rust-specific types. Since we don't want that, we extended the workflow to make everything private after the generation, but that's too strict because Swift expects some conformances to be public.

The goal of this task is to adjust that logic to only make private what needs to be private.

@pepicrft pepicrft added the bug Something isn't working label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant