From d6715710ed6b7cf8301d70f8df395b5c36087ea7 Mon Sep 17 00:00:00 2001
From: John Whittington <git@jbrengineering.co.uk>
Date: Mon, 20 Nov 2023 16:53:52 +0100
Subject: [PATCH] clippy on udev

---
 .github/workflows/build.yml |  4 ++--
 src/udev.rs                 | 25 ++++++++++---------------
 2 files changed, 12 insertions(+), 17 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index f0d81108..3b13d1c2 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -75,8 +75,8 @@ jobs:
         if: matrix.job.use-cross == false
         run: |
           cargo fmt -- --check
-          cargo clippy --all-targets
-          cargo clippy --all-targets --all-features
+          cargo clippy --all-targets -- -Dwarnings
+          cargo clippy --all-targets --all-features -- -Dwarnings
 
       - name: Test
         id: test
diff --git a/src/udev.rs b/src/udev.rs
index 2268ebc7..64f85528 100644
--- a/src/udev.rs
+++ b/src/udev.rs
@@ -24,13 +24,12 @@ pub struct UdevInfo {
 /// ```
 pub fn get_udev_info(port_path: &str) -> Result<UdevInfo, Error> {
     let path: String = format!("/sys/bus/usb/devices/{}", port_path);
-    let device = udevlib::Device::from_syspath(&Path::new(&path)).map_err(|e| {
+    let device = udevlib::Device::from_syspath(Path::new(&path)).map_err(|e| {
         Error::new(
             ErrorKind::Udev,
             &format!(
                 "Failed to get udev info for device at {}: Error({})",
-                path,
-                e.to_string()
+                path, e
             ),
         )
     })?;
@@ -54,13 +53,12 @@ pub fn get_udev_info(port_path: &str) -> Result<UdevInfo, Error> {
 /// ```
 pub fn get_udev_driver_name(port_path: &str) -> Result<Option<String>, Error> {
     let path: String = format!("/sys/bus/usb/devices/{}", port_path);
-    let device = udevlib::Device::from_syspath(&Path::new(&path)).map_err(|e| {
+    let device = udevlib::Device::from_syspath(Path::new(&path)).map_err(|e| {
         Error::new(
             ErrorKind::Udev,
             &format!(
                 "Failed to get udev info for device at {}: Error({})",
-                path,
-                e.to_string()
+                path, e
             ),
         )
     })?;
@@ -79,13 +77,12 @@ pub fn get_udev_driver_name(port_path: &str) -> Result<Option<String>, Error> {
 /// ```
 pub fn get_udev_syspath(port_path: &str) -> Result<Option<String>, Error> {
     let path: String = format!("/sys/bus/usb/devices/{}", port_path);
-    let device = udevlib::Device::from_syspath(&Path::new(&path)).map_err(|e| {
+    let device = udevlib::Device::from_syspath(Path::new(&path)).map_err(|e| {
         Error::new(
             ErrorKind::Udev,
             &format!(
                 "Failed to get udev info for device at {}: Error({})",
-                path,
-                e.to_string()
+                path, e
             ),
         )
     })?;
@@ -112,14 +109,12 @@ pub fn get_udev_attribute<T: AsRef<std::ffi::OsStr> + std::fmt::Display>(
     attribute: T,
 ) -> Result<Option<String>, Error> {
     let path: String = format!("/sys/bus/usb/devices/{}", port_path);
-    let device = udevlib::Device::from_syspath(&Path::new(&path)).map_err(|e| {
+    let device = udevlib::Device::from_syspath(Path::new(&path)).map_err(|e| {
         Error::new(
             ErrorKind::Udev,
             &format!(
                 "Failed to get udev attribute {} for device at {}: Error({})",
-                attribute,
-                path,
-                e.to_string()
+                attribute, path, e
             ),
         )
     })?;
@@ -150,7 +145,7 @@ pub fn hwdb_get(modalias: &str, key: &'static str) -> Result<Option<String>, Err
     let hwdb = udevlib::Hwdb::new().map_err(|e| {
         Error::new(
             ErrorKind::Udev,
-            &format!("Failed to get hwdb: Error({})", e.to_string()),
+            &format!("Failed to get hwdb: Error({})", e),
         )
     })?;
 
@@ -169,7 +164,7 @@ mod tests {
     fn test_udev_info() {
         let udevi = get_udev_info("1-0:1.0").unwrap();
         assert_eq!(udevi.driver, Some("hub".into()));
-        assert_eq!(udevi.syspath.unwrap().contains("usb1/1-0:1.0"), true);
+        assert!(udevi.syspath.unwrap().contains("usb1/1-0:1.0"));
     }
 
     /// Tests can lookup bInterfaceClass of the root hub, which is always 09