Skip to content
This repository has been archived by the owner on Jul 28, 2018. It is now read-only.

Not correctly inferring protocol with SSL, unless force_ssl is set #656

Open
chrisvfritz opened this issue Jan 8, 2016 · 2 comments
Open

Comments

@chrisvfritz
Copy link

Just tried the latest turbolinks on a site with SSL and every link on the page produced mixed content errors, resulting in all internal page visits being blocked by the browser. Yikes!

It may also be worth noting that I'm using Turbolinks.enableTransitionCache().

@chrisvfritz
Copy link
Author

It looks like that app wasn't forcing SSL in production.rb via config.force_ssl = true. It is now and turbolinks works! I'd hope not too many apps are using SSL without that option, but I think I'll rename the issue instead of closing it, because I'd expect at least one of these to happen:

  • When turbolinks is installed, but SSL is not forced either in the config or controller, pages served via SSL 500 with a useful error logged. This might not be feasible, because I can imagine cases where turbolinks might just not be used on SSL pages and this could be difficult to detect.
  • Turbolinks uses the same protocol as the current page for relative links, just like normal links do. (This would be my personal preference.)

@chrisvfritz chrisvfritz changed the title Broken with SSL Not correctly inferring protocol with SSL, unless force_ssl is set Jan 8, 2016
@Deuteu
Copy link

Deuteu commented Mar 1, 2016

difficult to detect

In my case on http page, turbolink changes it to https in the url so easy to detect but unwanted so second point would be great.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants