Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch module typing and use of the Headers class #11

Open
OlliV opened this issue Jan 11, 2020 · 0 comments
Open

Fetch module typing and use of the Headers class #11

OlliV opened this issue Jan 11, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@OlliV
Copy link
Collaborator

OlliV commented Jan 11, 2020

This might be a good idea:
https://github.com/zeit/fetch/pull/43/files

export default function SetupFetch(
	fetchModule?: FetchModule,
	agentOptions?: http.AgentOptions | https.AgentOptions
): Fetch;

Currently we avoid the issue by using the Headers class as implemented by node-fetch which might, in theory, be different and incompatible in some other implementation.

However, let's ensure that we align with Fetch Standard whenever possible.

@OlliV OlliV added the bug Something isn't working label Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant