Build error: wasi_snapshot_preview1: TypeError accessing 'includes' property

[jayaddison]

Hello,

I'm attempting to build the tutanota web client on Debian trixie (testing), and am mostly following the doc/BUILDING.md guide to do so (with some small deviations, such as working-around an insufficent npm version by using npm install npm to install a more-recent local copy).

When I get to the node webapp prod step, I'm encountering the following error (some file paths anonymised):

...
worker-search-CgUo851E.js  57.4921875K
        /src/mail-app/workerUtils/index/BulkMailLoader.ts
        /src/common/api/worker/search/DbFacade.ts
        /src/common/api/worker/search/SearchIndexEncoding.ts
        /src/common/api/worker/search/IndexUtils.ts
        /src/common/api/worker/search/IndexTables.ts
        /src/mail-app/workerUtils/index/ContactIndexer.ts
        /src/mail-app/workerUtils/index/IndexerCore.ts
        /src/mail-app/workerUtils/index/SuggestionFacade.ts
        /src/mail-app/workerUtils/index/Indexer.ts
        /src/mail-app/workerUtils/index/MailIndexer.ts
        /src/mail-app/workerUtils/index/SearchFacade.ts
SYNTHETIC MODULE?? wasi_snapshot_preview1

Build error: TypeError: Cannot read properties of null (reading 'includes')
    at getChunkName (file:///build/path/tutanota/buildSrc/RollupConfig.js:157:11)
    at Object.generateBundle (file:///build/path/tutanota/buildSrc/RollupConfig.js:397:29)
    at Object.handler (file:///build/path/tutanota/node_modules/rollup/dist/es/shared/node-entry.js:15311:45)
    at file:///build/path/tutanota/node_modules/rollup/dist/es/shared/node-entry.js:20730:40 {
  code: 'PLUGIN_ERROR',
  plugin: 'bundle-dependency-check',
  hook: 'generateBundle'
}

This fails the build. Has anyone here also encountered that and/or have ideas for how to resolve the problem?

Thank you!
James

[charlag]

Hey, from the error it's not where clear where the issue comes from. It may have something to do with WASM and its JS fallback.

We tried it with trixie container, but we had to pull nodejs from the outside (like here: https://gitlab.com/fdroid/fdroiddata/-/blob/56cbd36367dd73106daa91be51d7a1926ad9c0db/metadata/de.tutao.tutanota.yml#L4243-L4246 )

[jayaddison]

Thank you for taking a look. I'll re-attempt the build within the next day or two to reconfirm this and/or report back. I believe I was using nodejs v20.19.0 from trixie.

[jayaddison]

I've achieved a successful build from scratch using a fresh OCI container image of debian:trixie (testing) -- so I can only surmise that last time I did not follow the instructions correctly.

Two small notes:

• The NPM CLI isn't listed as an explicit dependency in the BUILDING.md file. Most people would probably figure out to install it, but perhaps I could offer a small pull request to add that?
• My first and second attempts at a build of tutanota-release-287.250523.0 using node webapp prod encountered a heap limit Allocation failed error from Node -- I found that adding the --max-old-space-size=8192 option (8GB) resolved this. Similarly: would that be worth adding to the documentation?

[jayaddison]

My report here seems to have been invalid and perhaps due to a mistake/unclean build environment.